Review main Merged

47950[BUGFIX] Harden database select step

Helmut Hummel CR +2 V +2 Easy +22 −3 updated 04/29/16, 09:47

Commit message

Currently this step does not do precautions, when
the selected database does not exist. Additionally the step
silently skips when the chosen database already has tables.

Although the UI currently does not allow to select a non
empty database, there are situations imaginable, where the database
is empty during generation of the input form but is filled directly after that,
or a database was empty but then got deleted,
which previously ended up with a fatal error.

This change now takes care of both cases and outputs a nice error message accordingly.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Daniel Goerz +1
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Jigal van Hemert +2
    • Daniel Goerz +1

Issues 1

Files 1

Review log 7

  1. Helmut Hummel uploaded patch set 1 04/28/16, 10:37

  2. Wouter Wolters voted on patch set 1 CR +1 04/28/16, 12:01

  3. Markus Klein voted on patch set 1 CR +1 04/28/16, 12:12

  4. Jigal van Hemert voted on patch set 1 CR +1 V +1 04/28/16, 13:15

  5. Daniel Goerz voted on patch set 1 CR +1 V +1 04/29/16, 09:16

  6. Jigal van Hemert commented on patch set 1 CR +2 V +2 04/29/16, 09:47

    Enough votes
  7. Gerrit merged patch set 1 04/29/16, 09:47