47966[BUGFIX] Use non-deprecated name for filesPerPage option
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Daniel Goerz +1
- Markus Sommer +1
- Wouter Wolters +1
-
Verified V +2
- Jigal van Hemert +2
- Markus Sommer +1
Issues 2
Files 2
Review log 13
-
Stephan Großberndt uploaded patch set 1 04/29/16, 08:47
-
Wouter Wolters voted on patch set 1 CR +1 04/29/16, 08:51
-
Daniel Goerz commented on patch set 1 04/29/16, 09:08
-
Stephan Großberndt commented on patch set 1 04/29/16, 09:09
FileList.php:200ReplyThis was introduced after 8.0 release and before 8.1. So better fix this now before the release. -
Daniel Goerz commented on patch set 1 CR +1 04/29/16, 09:14
FileList.php:200ReplyAh, alright then. -
Stephan Großberndt uploaded patch set 2 04/29/16, 09:25
-
Daniel Goerz voted on patch set 2 CR +1 04/29/16, 09:26
-
Stephan Großberndt commented on patch set 2 04/29/16, 09:27
There are several usages of options.file_list - so why not use that one instead of options.fileList -
Jigal van Hemert voted on patch set 2 CR +1 V +1 04/29/16, 09:34
-
Wouter Wolters voted on patch set 2 CR +1 04/29/16, 10:15
-
Markus Sommer voted on patch set 2 CR +1 V +1 04/29/16, 10:45
-
Jigal van Hemert commented on patch set 2 CR +2 V +2 04/29/16, 11:04
Enough votes -
Gerrit merged patch set 2 04/29/16, 11:04
FileList.php:200