Review main Merged

47966[BUGFIX] Use non-deprecated name for filesPerPage option

Stephan Großberndt CR +2 V +2 Easy +2 −2 updated 04/29/16, 11:04

Commit message

Change the configuration name for the filesPerPage option in the file
list module from mod.file_list.filesPerPage to
options.file_list.filesPerPage because using "mod." in user TSconfig
is deprecated.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Daniel Goerz +1
    • Markus Sommer +1
    • Wouter Wolters +1
  • Verified V +2
    • Jigal van Hemert +2
    • Markus Sommer +1

Issues 2

Files 2

Review log 13

  1. Stephan Großberndt uploaded patch set 1 04/29/16, 08:47

  2. Wouter Wolters voted on patch set 1 CR +1 04/29/16, 08:51

  3. Daniel Goerz commented on patch set 1 04/29/16, 09:08

    FileList.php:200

    Isn't this breaking?
  4. Stephan Großberndt commented on patch set 1 04/29/16, 09:09

    FileList.php:200 Reply

    This was introduced after 8.0 release and before 8.1. So better fix this now before the release.
  5. Daniel Goerz commented on patch set 1 CR +1 04/29/16, 09:14

    FileList.php:200 Reply

    Ah, alright then.
  6. Stephan Großberndt uploaded patch set 2 04/29/16, 09:25

  7. Daniel Goerz voted on patch set 2 CR +1 04/29/16, 09:26

  8. Stephan Großberndt commented on patch set 2 04/29/16, 09:27

    There are several usages of options.file_list - so why not use that one instead of options.fileList
  9. Jigal van Hemert voted on patch set 2 CR +1 V +1 04/29/16, 09:34

  10. Wouter Wolters voted on patch set 2 CR +1 04/29/16, 10:15

  11. Markus Sommer voted on patch set 2 CR +1 V +1 04/29/16, 10:45

  12. Jigal van Hemert commented on patch set 2 CR +2 V +2 04/29/16, 11:04

    Enough votes
  13. Gerrit merged patch set 2 04/29/16, 11:04