Review TYPO3_7-6 Merged

47967[BUGFIX] Harden database select step

Jigal van Hemert CR +2 V +2 Easy +22 −3 updated 05/07/16, 09:36

Commit message

Currently this step does not do precautions, when
the selected database does not exist. Additionally the step
silently skips when the chosen database already has tables.

Although the UI currently does not allow to select a non
empty database, there are situations imaginable, where the database
is empty during generation of the input form but is filled directly
after that, or a database was empty but then got deleted, which
previously ended up with a fatal error.

This change now takes care of both cases and outputs a nice error
message accordingly.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Helmut Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Helmut Hummel +1

Issues 1

Files 1

Review log 9

  1. Jigal van Hemert uploaded patch set 1 04/29/16, 10:53

  2. Helmut Hummel uploaded patch set 2 04/29/16, 19:12

  3. Sascha Egerer commented on patch set 2 CR -1 04/29/16, 19:40

    DatabaseSelect.php:80

    use $errorStatus = $this->objectManager->get(\TYPO3\CMS\Install\Status\ErrorStatus::class); instead

    DatabaseSelect.php:89

    same as above
  4. Sascha Egerer commented on patch set 2 CR 0 04/29/16, 19:44

    Ah looks like it has been changed in master.... so no opininon on that. Removed my -1 But i thought i could remember that GeneralUtility should not be used in the Install tool. But looks like this is not the case (anymore?)
  5. Helmut Hummel uploaded patch set 3 04/30/16, 01:04

  6. Helmut Hummel commented on patch set 3 CR +1 V +1 04/30/16, 01:05

    @Sascha: good catch, thanks. although even "new" would have worked here, it is better to have this consistent!
  7. Wouter Wolters voted on patch set 3 CR +1 05/06/16, 19:21

  8. Wouter Wolters voted on patch set 3 CR +2 V +2 05/07/16, 09:36

  9. Gerrit merged patch set 3 05/07/16, 09:36