47967[BUGFIX] Harden database select step
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Helmut Hummel +1
-
Verified V +2
- Wouter Wolters +2
- Helmut Hummel +1
Issues 1
Files 1
Review log 9
-
Jigal van Hemert uploaded patch set 1 04/29/16, 10:53
-
Helmut Hummel uploaded patch set 2 04/29/16, 19:12
-
Sascha Egerer commented on patch set 2 CR -1 04/29/16, 19:40
DatabaseSelect.php:89same as above -
Sascha Egerer commented on patch set 2 CR 0 04/29/16, 19:44
Ah looks like it has been changed in master.... so no opininon on that. Removed my -1 But i thought i could remember that GeneralUtility should not be used in the Install tool. But looks like this is not the case (anymore?) -
Helmut Hummel uploaded patch set 3 04/30/16, 01:04
-
Helmut Hummel commented on patch set 3 CR +1 V +1 04/30/16, 01:05
@Sascha: good catch, thanks. although even "new" would have worked here, it is better to have this consistent! -
Wouter Wolters voted on patch set 3 CR +1 05/06/16, 19:21
-
Wouter Wolters voted on patch set 3 CR +2 V +2 05/07/16, 09:36
-
Gerrit merged patch set 3 05/07/16, 09:36
DatabaseSelect.php:80