Review main Merged

47970[DOCS] Proofread 8.1 docs

Mathias Schreiber CR +2 V +2 Normal +153 −96 updated 05/03/16, 09:54

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1

Files 38

Show 18 more files

Review log 11

  1. Mathias Schreiber uploaded patch set 1 04/29/16, 11:56

  2. Michael Oehlhof commented on patch set 1 04/29/16, 12:55

    Only a few little nitpicks found

    Deprecation-73209-GlobalFlexPageTsConfig.rst:24

    1 empty line is missing

    Deprecation-73209-GlobalFlexPageTsConfig.rst:31

    1 empty line is missing

    Deprecation-75371-Array2xml_cs.rst:31

    Is it OK to use TAB in stead of space here?

    Deprecation-75625-DeprecatedCacheClearingOptions.rst:30

    Is one ` enough? At other places two of them are used. (For example in Feature-75454-DoctrineDBALForDatabaseConnections.rst at line 42)
  3. Markus Klein commented on patch set 1 04/29/16, 15:02

    Breaking-75711-RemovedDB-relatedMethodsAndTCA-relatedOptionsFromCObj.rst:20

    should we rather use $GLOBALS['TCA'] ?

    Deprecation-75340-MethodsRelatedToGeneratingTraditionalBackendAJAXURLs.rst:30

    maybe also note that the entry method of the ajax call needs to be adjusted to psr-7 too!

    Deprecation-75340-MethodsRelatedToGeneratingTraditionalBackendAJAXURLs.rst:32

    is this a php code block by default?

    Deprecation-75621-GeneralUtilityMethods.rst:39

    native

    Feature-75579-AddMarkupIdentifierSupportToJavaScriptIconAPI.rst:11

    it's

    Feature-75579-AddMarkupIdentifierSupportToJavaScriptIconAPI.rst:13

    by
  4. Susi Moog commented on patch set 1 04/30/16, 08:37

    Breaking-70056-CurlAndHttpRequestRemoved.rst:57

    do we use british or american English?

    Breaking-70056-CurlAndHttpRequestRemoved.rst:59

    will behave unexpectedly "PHP code ... will result" sounds strange.

    Breaking-70056-CurlAndHttpRequestRemoved.rst:67

    library

    Breaking-72931-SearchFormControllerpi_list_browseresultsHasBeenRenamed.rst:9

    have been

    Breaking-75237-RemovalOfDivCe-bodytextMightCauseLayoutIssues.rst:14

    depend

    Breaking-75357-TYPO3_CONF_VARSBElockSSLOptionIsBoolean.rst:25

    again AE vs BE

    Breaking-75497-InlineBackendLayoutWizard.rst:22

    Any

    Breaking-75497-InlineBackendLayoutWizard.rst:22

    makes

    Breaking-75829-RemovedImportHandlingOfPre60Files.rst:16

    BE vs AE

    Breaking-75829-RemovedImportHandlingOfPre60Files.rst:25

    were

    Deprecation-73209-GlobalFlexPageTsConfig.rst:17

    in the previous rst files we used "FlexForm"

    Deprecation-73209-GlobalFlexPageTsConfig.rst:28

    cannot
  5. Mathias Schreiber uploaded patch set 2 04/30/16, 12:08

  6. Susi Moog commented on patch set 2 05/01/16, 08:55

    Deprecation-73209-GlobalFlexPageTsConfig.rst:9

    flexform

    Deprecation-73209-GlobalFlexPageTsConfig.rst:16

    flexform

    Deprecation-73209-GlobalFlexPageTsConfig.rst:38

    flexform
  7. Mathias Schreiber commented on patch set 3 05/02/16, 18:25

    Published edit on patch set 2.
  8. Benni Mack uploaded patch set 4 05/03/16, 09:44

  9. Benni Mack voted on patch set 4 CR +1 V +1 05/03/16, 09:50

  10. Christian Kuhn voted on patch set 4 CR +2 V +2 05/03/16, 09:54

  11. Gerrit merged patch set 4 05/03/16, 09:54