Review main Merged

47995[TASK] Hide new db settings in Configuration module

Jigal van Hemert CR +2 V +2 Easy +19 −2 updated 05/03/16, 13:41

Commit message

Just like the old db settings the new settings for doctrine should
not be displayed in the Configuration module. Old settings are also
blinded as they can still exist in AdditionalConfiguration.php

Only existing settings are overwritten, previously the blinded options
were added to the settings if they didn't exist.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Oliver Hader +1

Issues 1

Files 1

Review log 13

  1. Jigal van Hemert uploaded patch set 1 05/02/16, 21:12

  2. Wouter Wolters commented on patch set 1 05/02/16, 21:26

    Any reason to leave the old config in there as blinded?
  3. Jigal van Hemert commented on patch set 1 05/02/16, 21:38

    > Any reason to leave the old config in there as blinded? Just be on the safe side, but it actually shows a bug in the blinding logic: values aren't only overwritten but also added to the configuration. The check only checks the very first level.
  4. Andreas Kienast commented on patch set 1 05/03/16, 04:32

    Can we iterate over DB/Connection to blind any configuration and not only the default obe?
  5. Oliver Hader commented on patch set 1 05/03/16, 05:33

    Patch looks good, but I had the same feeling with the iterations as Andi mentioned - so that would need something additional to the array merging approach then - e.g. just define the path and fill all leaf-nodes with asterisks
  6. Jigal van Hemert uploaded patch set 2 05/03/16, 05:40

  7. Jigal van Hemert commented on patch set 2 05/03/16, 05:46

    The old settings are kept to blind them if they still exist in the AdditionalConfiguration.php The additional doctrine configurations are now also blinded by copying the items. This can be turned into a generic mechanism later; for now it's important to blind the settings quickly.
  8. Andreas Kienast voted on patch set 2 CR +1 V +1 05/03/16, 06:29

  9. Oliver Hader voted on patch set 2 CR +1 05/03/16, 10:09

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 05/03/16, 10:10

  11. Oliver Hader voted on patch set 2 V +1 05/03/16, 10:10

  12. Gerrit merged patch set 2 05/03/16, 10:13

  13. Helmut Hummel commented on patch set 3 05/03/16, 13:41

    Thanks for the quick reaction, patch and merge!