Review main Merged

48026[TASK] Pass guzzle exception with report in case getUrl fails

Markus Klein CR +2 V +2 Easy +1 −0 updated 05/06/16, 19:19

Commit message

GeneralUtility::getUrl() may fail. Guzzle provides detailed information
in the exception it throws upon error.
Allow consumers of getUrl() to make more detailed failure analysis
by passing on the raw exception with the report.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Nicole Hummel +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 7

  1. Markus Klein uploaded patch set 1 05/06/16, 14:21

  2. Nicole Hummel voted on patch set 1 CR +1 V +1 05/06/16, 17:50

  3. Wouter Wolters voted on patch set 1 CR +1 05/06/16, 18:17

  4. Wouter Wolters updated the commit message in patch set 2 05/06/16, 19:18

  5. Wouter Wolters voted on patch set 2 CR +1 V +1 05/06/16, 19:18

  6. Nicole Hummel voted on patch set 2 CR +2 V +2 05/06/16, 19:19

  7. Gerrit merged patch set 2 05/06/16, 19:19