48027[BUGFIX] Prevent temp file generation in Unit Test
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Wouter Wolters +1
- Andreas Kienast +1
-
Verified V +2
- Susi Moog +2
- Wouter Wolters +1
- Andreas Kienast +1
Issues 1
Files 1
Review log 11
-
Nicole Hummel uploaded patch set 1 05/06/16, 17:18
-
Wouter Wolters voted on patch set 1 CR +1 05/06/16, 17:25
-
Wouter Wolters commented on patch set 1 V +1 05/06/16, 19:20
Green on Unix. -
Andreas Kienast commented on patch set 1 CR +1 V +1 05/07/16, 08:49
I'm only giving +1, I can't test the patch on Windows.FileWriterTest.php:99I'm not completely sure about that slash on Windows. -
Nicole Hummel commented on patch set 1 05/07/16, 08:55
FileWriterTest.php:99ReplyForward slashes are not problem. Windows can handle forward and backward slashes and even a mix of them -
Susi Moog commented on patch set 1 CR +2 V +2 05/07/16, 08:57
tested on windows, works :) -
Gerrit merged patch set 1 05/07/16, 08:58
-
Nicole Hummel commented on patch set 2 05/07/16, 08:59
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 9b8d34ebc28d8eb9b940507856b9ba091c2ffeb0 -
Nicole Hummel commented on patch set 2 05/07/16, 09:05
Test doesn't exists in 6.2 - so no backport needed -
Stephan Großberndt commented on patch set 2 06/06/16, 19:17
Backport for 6.2 is missing. Please write a short note if its not to be backported. -
Nicole Hummel commented on patch set 2 06/07/16, 07:13
@Stephan: just few days ago I was wondering why the folder and file was still (again) on my system. Thanks for pointing this out. Done.