Review main Merged

48027[BUGFIX] Prevent temp file generation in Unit Test

Nicole Hummel CR +2 V +2 Easy +3 −2 updated 06/07/16, 07:13

Commit message

Running Unit Tests creates file /tmp/typo3.log. On Windows systems
this file is stored on the root of the drive. This patch uses the
defined temp folder for storing the file.

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Susi Moog +2
    • Wouter Wolters +1
    • Andreas Kienast +1

Issues 1

Files 1

Review log 11

  1. Nicole Hummel uploaded patch set 1 05/06/16, 17:18

  2. Wouter Wolters voted on patch set 1 CR +1 05/06/16, 17:25

  3. Wouter Wolters commented on patch set 1 V +1 05/06/16, 19:20

    Green on Unix.
  4. Andreas Kienast commented on patch set 1 CR +1 V +1 05/07/16, 08:49

    I'm only giving +1, I can't test the patch on Windows.

    FileWriterTest.php:99

    I'm not completely sure about that slash on Windows.
  5. Nicole Hummel commented on patch set 1 05/07/16, 08:55

    FileWriterTest.php:99 Reply

    Forward slashes are not problem. Windows can handle forward and backward slashes and even a mix of them
  6. Susi Moog commented on patch set 1 CR +2 V +2 05/07/16, 08:57

    tested on windows, works :)
  7. Gerrit merged patch set 1 05/07/16, 08:58

  8. Nicole Hummel commented on patch set 2 05/07/16, 08:59

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 9b8d34ebc28d8eb9b940507856b9ba091c2ffeb0
  9. Nicole Hummel commented on patch set 2 05/07/16, 09:05

    Test doesn't exists in 6.2 - so no backport needed
  10. Stephan Großberndt commented on patch set 2 06/06/16, 19:17

    Backport for 6.2 is missing. Please write a short note if its not to be backported.
  11. Nicole Hummel commented on patch set 2 06/07/16, 07:13

    @Stephan: just few days ago I was wondering why the folder and file was still (again) on my system. Thanks for pointing this out. Done.