Review main Merged

48031[TASK] Hide selected items in multipleSideBySide

Andreas Kienast CR +2 V +2 Normal +44 −19 updated 05/10/16, 11:34

Commit message

If a multipleSideBySide form element is not allowed to add the same
value multiple times, its selected values are hidden now and it's not
possible to add them again unless the values are removed from the
selection.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Nicole Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Nicole Hummel +1

Issues 1

Files 2

Review log 26

Show 1 earlier messages
  1. Andreas Kienast uploaded patch set 1 05/07/16, 08:30

  1. Andreas Kienast updated the commit message in patch set 2 05/07/16, 08:33

  2. Nicole Hummel commented on patch set 2 05/07/16, 09:11

    SelectMultipleSideBySideElement.php:92

    !empty()?

    SelectMultipleSideBySideElement.php:104

    disabled="disabled"

    SelectMultipleSideBySideElement.php:107

    If you add spaces to the variables above, you can skip them here

    FormEngine.js:88

    variable name missing
  3. Wouter Wolters commented on patch set 2 05/07/16, 09:14

    SelectMultipleSideBySideElement.php:103

    3rd parameter of in_array true
  4. Wouter Wolters commented on patch set 2 CR -1 05/07/16, 09:24

    this fails when you select first Show at any login and after that Hide at login. The first option is not back in the list of items to choose.
  5. Andreas Kienast commented on patch set 2 CR -1 05/07/16, 11:05

    on it
  6. Andreas Kienast commented on patch set 2 05/07/16, 11:07

    SelectMultipleSideBySideElement.php:104 Reply

    That's not required, the backend runs with the HTML 5 doctype.
  7. Andreas Kienast uploaded patch set 3 05/07/16, 11:15

  8. Wouter Wolters uploaded patch set 4 05/07/16, 11:21

  9. Wouter Wolters commented on patch set 4 CR -1 05/07/16, 11:39

    If you have a selection saved. For example Hide at login. And open the element again you have Hide at login still in the list to be selected. IMO this should be removed there.
  10. Andreas Kienast uploaded patch set 5 05/07/16, 12:02

  11. Andreas Kienast uploaded patch set 6 05/07/16, 12:05

  12. Andreas Kienast uploaded patch set 7 05/07/16, 12:08

  13. Wouter Wolters voted on patch set 7 CR +1 V +1 05/07/16, 12:09

  14. Markus Klein commented on patch set 7 05/08/16, 17:15

    Why not 7.6??
  15. Andreas Kienast commented on patch set 7 05/08/16, 17:17

    It changes the behavior of multipleSideBySide, that's IMHO too intrusive for 7.6.
  16. Markus Klein updated the commit message in patch set 8 05/08/16, 17:25

  17. Markus Klein voted on patch set 8 CR +1 05/08/16, 17:26

  18. Nicole Hummel voted on patch set 8 CR +1 V +1 05/09/16, 12:59

  19. Wouter Wolters voted on patch set 8 CR +1 V +1 05/09/16, 13:07

  20. Markus Klein voted on patch set 8 CR +2 V +2 05/10/16, 08:00

  21. Gerrit merged patch set 8 05/10/16, 08:00

  22. Markus Klein commented on patch set 9 05/10/16, 08:01

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit f8193243ba181903613f0418a3a8205be13c54b9
  23. Adrian Mot commented on patch set 9 05/10/16, 08:37

    FormEngine.js:566

    Running fine if you select only one option to remove. If you select multiple, they will not reach the "available options" field.
  24. Andreas Kienast commented on patch set 9 05/10/16, 08:39

    Good catch, will push a follow up asap
  25. Nicole Hummel commented on patch set 9 05/10/16, 11:34

    I'm not able to add records to a group/db field anymore. Ending with error: Fehler: TypeError: $optionEl is undefined Quelldatei: http://master.typo3.local/typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js?bust=1462880002 Zeile: 133