48031[TASK] Hide selected items in multipleSideBySide
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
- Nicole Hummel +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
- Nicole Hummel +1
Issues 1
Files 2
Review log 26
Show 1 earlier messages
-
Andreas Kienast uploaded patch set 1 05/07/16, 08:30
-
Andreas Kienast updated the commit message in patch set 2 05/07/16, 08:33
-
Nicole Hummel commented on patch set 2 05/07/16, 09:11
SelectMultipleSideBySideElement.php:104disabled="disabled"SelectMultipleSideBySideElement.php:107If you add spaces to the variables above, you can skip them hereFormEngine.js:88variable name missing -
Wouter Wolters commented on patch set 2 05/07/16, 09:14
SelectMultipleSideBySideElement.php:1033rd parameter of in_array true -
Wouter Wolters commented on patch set 2 CR -1 05/07/16, 09:24
this fails when you select first Show at any login and after that Hide at login. The first option is not back in the list of items to choose. -
Andreas Kienast commented on patch set 2 CR -1 05/07/16, 11:05
on it -
Andreas Kienast commented on patch set 2 05/07/16, 11:07
SelectMultipleSideBySideElement.php:104ReplyThat's not required, the backend runs with the HTML 5 doctype. -
Andreas Kienast uploaded patch set 3 05/07/16, 11:15
-
Wouter Wolters uploaded patch set 4 05/07/16, 11:21
-
Wouter Wolters commented on patch set 4 CR -1 05/07/16, 11:39
If you have a selection saved. For example Hide at login. And open the element again you have Hide at login still in the list to be selected. IMO this should be removed there. -
Andreas Kienast uploaded patch set 5 05/07/16, 12:02
-
Andreas Kienast uploaded patch set 6 05/07/16, 12:05
-
Andreas Kienast uploaded patch set 7 05/07/16, 12:08
-
Wouter Wolters voted on patch set 7 CR +1 V +1 05/07/16, 12:09
-
Markus Klein commented on patch set 7 05/08/16, 17:15
Why not 7.6?? -
Andreas Kienast commented on patch set 7 05/08/16, 17:17
It changes the behavior of multipleSideBySide, that's IMHO too intrusive for 7.6. -
Markus Klein updated the commit message in patch set 8 05/08/16, 17:25
-
Markus Klein voted on patch set 8 CR +1 05/08/16, 17:26
-
Nicole Hummel voted on patch set 8 CR +1 V +1 05/09/16, 12:59
-
Wouter Wolters voted on patch set 8 CR +1 V +1 05/09/16, 13:07
-
Markus Klein voted on patch set 8 CR +2 V +2 05/10/16, 08:00
-
Gerrit merged patch set 8 05/10/16, 08:00
-
Markus Klein commented on patch set 9 05/10/16, 08:01
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit f8193243ba181903613f0418a3a8205be13c54b9 -
Adrian Mot commented on patch set 9 05/10/16, 08:37
FormEngine.js:566Running fine if you select only one option to remove. If you select multiple, they will not reach the "available options" field. -
Andreas Kienast commented on patch set 9 05/10/16, 08:39
Good catch, will push a follow up asap -
Nicole Hummel commented on patch set 9 05/10/16, 11:34
I'm not able to add records to a group/db field anymore. Ending with error: Fehler: TypeError: $optionEl is undefined Quelldatei: http://master.typo3.local/typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js?bust=1462880002 Zeile: 133
SelectMultipleSideBySideElement.php:92