48034[TASK] Deprecate the $icon setter/getter in the Extbase Category model
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Georg Ringer +1
- Paul Ilea +1
- Marcin Krzyżanowski +1
- Nicole Hummel +1
-
Verified V +2
- Anja Leichsenring +2
- Georg Ringer +1
Issues 1
Files 2
Review log 16
-
Wouter Wolters uploaded patch set 1 05/07/16, 12:05
-
Mathias Brodala commented on patch set 1 05/09/16, 06:46
Should we add at least an Important RST in case 3rd party code has actually used this property? -
Paul Ilea commented on patch set 1 CR -1 05/09/16, 10:16
The removed methods are marked as API methods, so I think we should go with the "deprecated" strategy and remove it later. -
Paul Ilea uploaded patch set 2 05/09/16, 11:35
-
Nicole Hummel commented on patch set 2 CR -1 05/09/16, 12:28
Category.php:96We should remove the api annotation.Category.php:110We should remove the api annotation. -
Wouter Wolters commented on patch set 3 05/11/16, 08:53
Published edit on patch set 2. -
Marcin Krzyżanowski voted on patch set 3 CR +1 05/11/16, 08:59
-
Paul Ilea voted on patch set 3 CR +1 05/11/16, 09:03
-
Nicole Hummel voted on patch set 3 CR +1 05/11/16, 10:37
-
Nicole Hummel commented on patch set 4 05/11/16, 10:39
Published edit on patch set 3. -
Nicole Hummel voted on patch set 4 CR +1 05/11/16, 10:39
-
Paul Ilea voted on patch set 4 CR +1 05/11/16, 10:45
-
Marcin Krzyżanowski voted on patch set 4 CR +1 05/11/16, 10:49
-
Georg Ringer voted on patch set 4 CR +1 V +1 05/11/16, 10:52
-
Anja Leichsenring voted on patch set 4 CR +2 V +2 05/11/16, 10:57
-
Gerrit merged patch set 4 05/11/16, 10:57