Review main Merged

48034[TASK] Deprecate the $icon setter/getter in the Extbase Category model

Wouter Wolters CR +2 V +2 Easy +31 −2 updated 05/11/16, 10:57

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Paul Ilea +1
    • Marcin Krzyżanowski +1
    • Nicole Hummel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Georg Ringer +1

Issues 1

Files 2

Review log 16

  1. Wouter Wolters uploaded patch set 1 05/07/16, 12:05

  2. Mathias Brodala commented on patch set 1 05/09/16, 06:46

    Should we add at least an Important RST in case 3rd party code has actually used this property?
  3. Paul Ilea commented on patch set 1 CR -1 05/09/16, 10:16

    The removed methods are marked as API methods, so I think we should go with the "deprecated" strategy and remove it later.
  4. Paul Ilea uploaded patch set 2 05/09/16, 11:35

  5. Nicole Hummel commented on patch set 2 CR -1 05/09/16, 12:28

    Category.php:96

    We should remove the api annotation.

    Category.php:110

    We should remove the api annotation.
  6. Wouter Wolters commented on patch set 3 05/11/16, 08:53

    Published edit on patch set 2.
  7. Marcin Krzyżanowski voted on patch set 3 CR +1 05/11/16, 08:59

  8. Paul Ilea voted on patch set 3 CR +1 05/11/16, 09:03

  9. Nicole Hummel voted on patch set 3 CR +1 05/11/16, 10:37

  10. Nicole Hummel commented on patch set 4 05/11/16, 10:39

    Published edit on patch set 3.
  11. Nicole Hummel voted on patch set 4 CR +1 05/11/16, 10:39

  12. Paul Ilea voted on patch set 4 CR +1 05/11/16, 10:45

  13. Marcin Krzyżanowski voted on patch set 4 CR +1 05/11/16, 10:49

  14. Georg Ringer voted on patch set 4 CR +1 V +1 05/11/16, 10:52

  15. Anja Leichsenring voted on patch set 4 CR +2 V +2 05/11/16, 10:57

  16. Gerrit merged patch set 4 05/11/16, 10:57