Review main Abandoned

48038[WIP][TASK] Improve wording of the condition loop of TypoScriptParser

Elmar Hinz CR 0 V 0 Easy +35 −10 updated 05/28/16, 05:27

Commit message

WIP annotation:

Georg Ringer suggest to set the renamed variable to protected in the
same step. Encapsulation. Hurray!

It seems this request made this ticket to complex in number targets
to get it reviewed.

I postpone this ticket now and do the full encapsulation of the class
first. Thereafter this ticket becomes more clear in the target.

1.) The sourcecode comments that describe the scope are improved.

2.) The boolean settings follow the phrasing:

    "The [ELSE] branch is selected, if the previous condition failed."

3.) The boolean values true and false are used to set the variable.

4.) The property becomes protected.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 13

  1. Elmar Hinz uploaded patch set 1 05/09/16, 00:44

  2. Elmar Hinz updated the commit message in patch set 2 05/09/16, 00:47

  3. Georg Ringer commented on patch set 2 05/09/16, 05:37

    as this is a public property, a rst file is needed and then please set it as protected if possible
  4. Elmar Hinz commented on patch set 2 05/09/16, 05:49

    > as this is a public property, a rst file is needed and then please > set it as protected if possible If it is a public property, do I need to mark it as breaking? In fact the logical purpose is for internal use only.
  5. Elmar Hinz uploaded patch set 3 05/09/16, 05:55

  6. Elmar Hinz updated the commit message in patch set 4 05/09/16, 06:44

  7. Elmar Hinz uploaded patch set 5 05/09/16, 07:19

  8. Elmar Hinz uploaded patch set 6 05/09/16, 07:22

  9. Wouter Wolters updated the commit message in patch set 7 05/09/16, 08:02

  10. Wouter Wolters commented on patch set 7 CR +1 05/09/16, 08:02

    No usage found in TER
  11. Elmar Hinz uploaded patch set 8 05/11/16, 06:19

  12. Elmar Hinz updated the commit message in patch set 9 05/11/16, 06:21

  13. Elmar Hinz abandoned the change 05/28/16, 05:27