Review main Merged

48044[BUGFIX] Use `find()` to get option tags from select

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 05/18/16, 12:42

Commit message

Using `children()` to get the option tags from the select fields
will fail if the select field contains `optgroup` tags (e.g. rendered
by a hook).

This patch replaces `children()` with `find()` to cover this
edge case.

Review

  • Code review CR +2
    • Markus Klein +2
    • Daniel Goerz +1
    • Frank Nägler +1
    • Oliver Hader +1
    • Nicole Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Frank Nägler +1
    • Oliver Hader +1
    • Nicole Hummel +1

Issues 1

Files 1

Review log 20

  1. Andreas Kienast uploaded patch set 1 05/09/16, 15:04

  2. Daniel Goerz voted on patch set 1 CR +1 05/09/16, 15:16

  3. Nicole Hummel uploaded patch set 2 05/10/16, 10:18

  4. Nicole Hummel commented on patch set 2 CR +1 05/10/16, 10:19

    Rebased
  5. Daniel Goerz voted on patch set 2 CR +1 05/10/16, 10:23

  6. Nicole Hummel commented on patch set 2 V -1 05/10/16, 11:12

    Adding new elements to select box isn't possible anymore
  7. Nicole Hummel commented on patch set 2 V +1 05/10/16, 11:32

    The other patch breaks the behaviour :-)
  8. Frank Nägler commented on patch set 2 CR -1 05/13/16, 12:29

    on it, rebasing
  9. Frank Nägler uploaded patch set 3 05/13/16, 12:35

  10. Frank Nägler voted on patch set 3 CR +1 V +1 05/13/16, 12:35

  11. Daniel Goerz voted on patch set 3 CR +1 05/13/16, 12:36

  12. Andreas Kienast commented on patch set 3 05/17/16, 08:18

    I've attached a test extension in the ticket to test the patch. This extension requires "styleguide". The extension manipulates the field "group_db_1" found in "Form engine elements - group" and adds optgroups.
  13. Oliver Hader voted on patch set 3 CR +1 05/17/16, 08:25

  14. Oliver Hader voted on patch set 3 V +1 05/17/16, 08:41

  15. Oliver Hader commented on patch set 3 05/17/16, 08:41

  16. Nicole Hummel voted on patch set 3 CR +1 05/17/16, 08:43

  17. Nicole Hummel voted on patch set 3 V +1 05/17/16, 08:43

  18. Markus Klein voted on patch set 3 CR +2 V +2 05/18/16, 12:42

  19. Markus Klein commented on patch set 3 05/18/16, 12:42

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 8168aad61adfadd2ebc8abd7d2f920e9492769c0
  20. Gerrit merged patch set 3 05/18/16, 12:42