48044[BUGFIX] Use `find()` to get option tags from select
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Daniel Goerz +1
- Frank Nägler +1
- Oliver Hader +1
- Nicole Hummel +1
-
Verified V +2
- Markus Klein +2
- Frank Nägler +1
- Oliver Hader +1
- Nicole Hummel +1
Issues 1
Files 1
Review log 20
-
Andreas Kienast uploaded patch set 1 05/09/16, 15:04
-
Daniel Goerz voted on patch set 1 CR +1 05/09/16, 15:16
-
Nicole Hummel uploaded patch set 2 05/10/16, 10:18
-
Nicole Hummel commented on patch set 2 CR +1 05/10/16, 10:19
Rebased -
Daniel Goerz voted on patch set 2 CR +1 05/10/16, 10:23
-
Nicole Hummel commented on patch set 2 V -1 05/10/16, 11:12
Adding new elements to select box isn't possible anymore -
Nicole Hummel commented on patch set 2 V +1 05/10/16, 11:32
The other patch breaks the behaviour :-) -
Frank Nägler commented on patch set 2 CR -1 05/13/16, 12:29
on it, rebasing -
Frank Nägler uploaded patch set 3 05/13/16, 12:35
-
Frank Nägler voted on patch set 3 CR +1 V +1 05/13/16, 12:35
-
Daniel Goerz voted on patch set 3 CR +1 05/13/16, 12:36
-
Andreas Kienast commented on patch set 3 05/17/16, 08:18
I've attached a test extension in the ticket to test the patch. This extension requires "styleguide". The extension manipulates the field "group_db_1" found in "Form engine elements - group" and adds optgroups. -
Oliver Hader voted on patch set 3 CR +1 05/17/16, 08:25
-
Oliver Hader voted on patch set 3 V +1 05/17/16, 08:41
-
Oliver Hader commented on patch set 3 05/17/16, 08:41
-
Nicole Hummel voted on patch set 3 CR +1 05/17/16, 08:43
-
Nicole Hummel voted on patch set 3 V +1 05/17/16, 08:43
-
Markus Klein voted on patch set 3 CR +2 V +2 05/18/16, 12:42
-
Markus Klein commented on patch set 3 05/18/16, 12:42
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 8168aad61adfadd2ebc8abd7d2f920e9492769c0 -
Gerrit merged patch set 3 05/18/16, 12:42