Review main Merged

48046[BUGFIX] Adds missing tablename sys_language in fetchOriginLanguage function

Wouter Wolters CR +2 V +2 Easy +2 −1 updated 01/06/19, 11:01

Commit message

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Christoph Kratz +1
    • Morton Jonuschat +1
    • Marvin Dettinger +1
  • Verified V +2
    • Nicole Hummel +2
    • Christoph Kratz +1
    • Morton Jonuschat +1
    • Marvin Dettinger +1

Issues 1

Files 1

Review log 14

  1. Wouter Wolters commented on patch set 1 05/09/16, 16:48

    Cherry Picked from branch TYPO3_7-6.
  2. Christoph Kratz voted on patch set 1 CR +1 V +1 05/10/16, 06:43

  3. Andreas Kienast commented on patch set 1 05/10/16, 06:52

    Is this coverable by the existing functional tests?
  4. Nicole Hummel commented on patch set 1 05/10/16, 07:34

    Do we fix code which is updated in a few days anyway? I would clean it up in 7.6 only
  5. Christian Kuhn commented on patch set 1 05/10/16, 07:36

    yes we fix code, even if it is changed later again.
  6. Morton Jonuschat commented on patch set 1 CR -1 05/10/16, 07:39

    This fix is as broken as the original implementation. The tables tt_content and sys_language are not joined or related to one another in any part of the query. The root cause IMHO is the call to $this->getAllowedLanguagesForBackendUser(). So either the fix needs to join the tables in a way that actually makes this a restriction or we can skip the getAllowedLanguagesForBackendUser() call
  7. Christoph Kratz commented on patch set 1 05/10/16, 07:51

    This commit was causing the problem: [BUGFIX] Correctly determine previously used language in localization wizard (Andreas Fernandez) Commit-Id: 5d38829 Change-Id: Ib6e1206adc6ccfd5b1e4816b9eb6562f8fc0e0ef
  8. Morton Jonuschat uploaded patch set 2 05/20/16, 13:00

  9. Morton Jonuschat voted on patch set 2 CR +1 V +1 05/20/16, 13:01

  10. Christoph Kratz voted on patch set 2 CR +1 V +1 05/24/16, 11:43

  11. Nicole Hummel voted on patch set 2 CR +2 V +2 05/24/16, 12:04

  12. Gerrit merged patch set 2 05/24/16, 12:04

  13. Marvin Dettinger voted on patch set 1 CR +1 V +1 01/06/19, 11:01

  14. Marvin Dettinger voted on patch set 2 CR +1 V +1 01/06/19, 11:01