48052[TASK] Added compatibility7 conflict specification in conf file
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Adrian Mot +1
- Wouter Wolters +1
- Nicole Hummel +1
- Helmut Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Nicole Hummel +1
- Helmut Hummel +1
Issues 1
Files 4
Review log 20
-
Adrian Mot uploaded patch set 1 05/10/16, 07:08
-
Nicole Hummel commented on patch set 1 05/10/16, 10:15
You curious if there is any real conflict. -
Christian Kuhn commented on patch set 1 05/10/16, 13:26
No, there is no real conflict, afaik (yet). But we think that if you're using compat6 and you then upgrade to v8, you really really should not use compat6 AND compat7 in parallel. We will not support that at all, so it is much better to let it conflict in the first place. Is this ok with you? -
Andreas Kienast commented on patch set 1 05/10/16, 14:15
ext_emconf.php:19Musn't that be 'compatibility6' => '' ? -
Nicole Hummel uploaded patch set 2 05/10/16, 16:43
-
Nicole Hummel commented on patch set 2 CR +1 05/10/16, 16:44
This patch can't get verified as the EM doesn't care about conflicts -
Christian Kuhn commented on patch set 2 05/12/16, 11:16
kk, still, lets go for it, i'd say, but we should add it to composer.json, too. -
Christian Kuhn uploaded patch set 3 05/12/16, 11:25
-
Christian Kuhn uploaded patch set 4 05/12/16, 11:26
-
Christian Kuhn uploaded patch set 5 05/12/16, 11:28
-
Christian Kuhn uploaded patch set 6 05/12/16, 11:31
-
Christian Kuhn uploaded patch set 7 05/12/16, 11:32
-
Helmut Hummel voted on patch set 7 CR +1 V +1 05/12/16, 11:34
-
Nicole Hummel voted on patch set 7 CR +1 05/12/16, 11:34
-
Christian Kuhn commented on patch set 7 CR +1 V +1 05/12/16, 11:35
composer.json:146helmut made me do that since compat7 will be excluded from core later and this fixes the autoloading for it.composer.json:3helmut made me do that since compat7 will be excluded from core later and this fixes the autoloading for it. -
Nicole Hummel voted on patch set 7 V +1 05/12/16, 11:35
-
Adrian Mot voted on patch set 7 CR +1 05/12/16, 11:35
-
Wouter Wolters voted on patch set 7 CR +1 05/12/16, 11:41
-
Christian Kuhn voted on patch set 7 CR +2 V +2 05/12/16, 14:56
-
Gerrit merged patch set 7 05/12/16, 14:57