Review main Merged

48061[BUGFIX] Allow to add custom styles for admin panel

Zbigniew Jacko CR +2 V +2 Easy +4 −5 updated 06/07/16, 14:18

Commit message

Allow to add custom styles for admin panel, which are included 
below the main styles.

Review

  • Code review CR +2
    • Susi Moog +2
    • Marcin Krzyżanowski +1
    • Jörg Bösche +1
    • Nicole Hummel +1
  • Verified V +2
    • Susi Moog +2
    • Marcin Krzyżanowski +1
    • Jörg Bösche +1

Issues 1

Files 2

Review log 21

  1. Zbigniew Jacko uploaded patch set 1 05/10/16, 10:52

  2. Zbigniew Jacko rebased onto patch set 2 05/10/16, 10:58

  3. Nicole Hummel commented on patch set 2 CR +1 05/10/16, 11:45

    Should this patch be backported to 7.6 as there is the same code available.
  4. Zbigniew Jacko updated the commit message in patch set 3 05/10/16, 12:27

  5. Nicole Hummel voted on patch set 3 CR +1 05/10/16, 12:28

  6. Marcin Krzyżanowski voted on patch set 3 CR +1 V +1 05/10/16, 12:38

  7. Tymoteusz Motylewski commented on patch set 3 05/10/16, 21:51

    I would prefer having the commit title saying what is changed instead of what was wrong. see https://wiki.typo3.org/CommitMessage_Format_(Git)
  8. Zbigniew Jacko updated the commit message in patch set 4 05/11/16, 06:46

  9. Nicole Hummel voted on patch set 4 CR +1 05/11/16, 07:17

  10. Marcin Krzyżanowski voted on patch set 4 CR +1 V +1 05/11/16, 07:18

  11. Tymoteusz Motylewski commented on patch set 4 05/13/16, 08:23

    this is a regression fix, right? can we add information about that in the commit message?
  12. Benjamin Kott commented on patch set 4 05/27/16, 13:12

    If this is a bugfix we can backport it - in my personal oppinion we should remove the functionality completly from cms 8 and get the admin panel fixed, then it should not be nessesary anymore to correct it with custom styles.
  13. Frank Nägler commented on patch set 4 05/27/16, 13:14

    +1 for remove this functionality
  14. Benni Mack commented on patch set 4 05/27/16, 14:24

    OK. This might be a bit more tricky than it looks like in the beginning. a) the in-house adminpanel.css is added when the admin panel is visible AND/OR the frontend editing is active. b) if you set 
$GLOBALS['TBE_STYLES']['stylesheets']['admPanel'] to something else within your extenison (or to 'fileadmin/main.css') then adminpanel.css only gets loaded once + my custom css file. Did I miss anything?

  15. Benni Mack voted on patch set 4 CR -1 05/30/16, 12:33

  16. Benni Mack commented on patch set 4 CR 0 05/30/16, 12:33

    ok. fine with me like it is.
  17. Susi Moog voted on patch set 4 CR +1 V +1 06/07/16, 13:18

  18. Jörg Bösche voted on patch set 4 CR +1 V +1 06/07/16, 13:29

  19. Susi Moog voted on patch set 4 CR +2 V +2 06/07/16, 14:17

  20. Gerrit merged patch set 4 06/07/16, 14:17

  21. Susi Moog commented on patch set 5 06/07/16, 14:18

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit e171694160b8e9b36b2c52bde1b449aa1763327a