48062[FOLLOWUP][TASK] Hide selected items in multipleSideBySide
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Daniel Goerz +1
- Markus Klein +1
- Nicole Hummel +1
-
Verified V +2
- Anja Leichsenring +2
- Tomita Militaru +1
- Nicole Hummel +1
Issues 1
Files 1
Review log 27
Show 2 earlier messages
-
Markus Klein commented on patch set 1 CR -1 05/10/16, 15:23
reviewing -
Markus Klein commented on patch set 1 CR 0 05/10/16, 15:33
FormEngine.js:573isn't 'item' already a jquery object? I propose to use $(this) instead of defining parameters in the closure. -
Andreas Kienast commented on patch set 1 05/10/16, 16:11
FormEngine.js:573ReplyNope, item is a native DOMElement -
Tomita Militaru commented on patch set 1 V -1 05/11/16, 07:48
Tried it on Windows 10, Chrome latest - the following error is thrown when selecting a value in element browser: Uncaught TypeError: Cannot read property 'length' of null Because of that, the window doesn't close anymore. -
Nicole Hummel commented on patch set 1 V -1 05/11/16, 08:00
Can reproduce the error on Chrome/Windows 7 as well -
Adrian Mot voted on patch set 1 CR +1 05/11/16, 08:41
-
Nicole Hummel commented on patch set 1 V +1 05/11/16, 18:26
The problem is not this patch, but https://review.typo3.org/48067/ If you revert that one, no error is thrown anymore -
Markus Klein commented on patch set 2 05/11/16, 18:56
Published edit on patch set 1. -
Markus Klein voted on patch set 2 CR +1 05/11/16, 18:57
-
Nicole Hummel voted on patch set 2 CR +1 V +1 05/11/16, 19:26
-
Tomita Militaru commented on patch set 2 V -1 05/11/16, 19:52
Error is still thrown when clicking on an item (not the plus sign) - Uncaught TypeError: Cannot read property 'length' of null -
Andreas Kienast uploaded patch set 3 05/12/16, 07:09
-
Tomita Militaru commented on patch set 3 CR +1 V +1 05/12/16, 12:34
Works! -
Andreas Kienast uploaded patch set 4 05/12/16, 12:59
-
Andreas Kienast commented on patch set 4 05/12/16, 12:59
Reverted to PS2 after Nicole stated that my patch is not related to the reported "undefined" error -
Nicole Hummel commented on patch set 4 CR +1 V +1 05/12/16, 13:10
For the mentioned Chrome problem, please see https://review.typo3.org/48084/1 -
Tomita Militaru commented on patch set 4 V -1 05/12/16, 13:59
Problem is back again in Chrome, Windows 10: Uncaught TypeError: Cannot read property 'length' of null -
Nicole Hummel commented on patch set 4 05/12/16, 14:23
@Tomita have you read my remarks? -
Tomita Militaru commented on patch set 4 05/12/16, 14:34
My bad, misunderstood. -
Tomita Militaru voted on patch set 4 V +1 05/12/16, 14:34
-
Markus Klein voted on patch set 4 CR +1 05/12/16, 14:56
-
Daniel Goerz voted on patch set 4 CR +1 05/12/16, 15:33
-
Anja Leichsenring voted on patch set 4 CR +2 V +2 05/12/16, 16:02
-
Gerrit merged patch set 4 05/12/16, 16:02
-
Anja Leichsenring commented on patch set 5 05/12/16, 16:02
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 4913b98e304d6bd5f9a77afa84f06a58dd976074