Review TYPO3_7-6 Merged

48064[TASK] Loosen Symfony components version constraint

Mathias Brodala CR +2 V +2 Hard +159 −98 updated 11/29/16, 14:32

Commit message

Allow installation with Symfony components of 2.8 branch
but continue to disallow 3.x.

Update our lock file accordingly

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Peter Foerger +1
  • Verified V +2
    • Helmut Hummel +2
    • Stefan Neufeind +1
    • Peter Foerger +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 2831

Show 6 earlier messages
  1. Mathias Brodala uploaded patch set 1 05/10/16, 13:55

  2. Elmar Hinz voted on patch set 1 CR +1 05/10/16, 14:27

  3. Elmar Hinz commented on patch set 1 CR 0 05/10/16, 14:30

    Commit msg says 2.8 branch, but you allow 2.7.
  4. Mathias Brodala commented on patch set 1 05/10/16, 14:41

    No, I allow ~2.7 which includes 2.8. :-)
  5. Elmar Hinz commented on patch set 1 05/10/16, 15:04

    > No, I allow ~2.7 which includes 2.8. :-) ~1.2 is equivalent to >=1.2 <2.0.0 And even 2.22 not just 2.8. :)
  6. Elmar Hinz voted on patch set 1 CR +1 05/10/16, 15:06

  1. Elmar Hinz commented on patch set 1 05/11/16, 04:35

    > No, I allow ~2.7 which includes 2.8. :-) Personally its' my opinion, that release versions should not set wildcards at all, but use fixed ranges of tested versions. But that would be a full change of the current practice. Using wildcards is giving up control in favour of more easy upgrading. That is perfect during development but could result in issues with production systems out there.
  2. Mathias Brodala commented on patch set 1 05/11/16, 08:20

    Yes, in a normal case something like this could be dangerous if a dependency does not follow semver but there never will be a 2.9 or similar for Symfony. ;-)
  3. Helmut Hummel commented on patch set 1 CR -1 06/01/16, 16:11

    are you 100% sure that our usage in ConsoleOutput will work and will not throw deprecation messages, when console 2.8.x is used? This is minor update in our dependencies which will enventually be released as bugfix TYPO3 release. imho this does not fit well
  4. Mathias Brodala commented on patch set 1 06/02/16, 07:32

    > are you 100% sure that our usage in ConsoleOutput will work and > will not throw deprecation messages, when console 2.8.x is used? I am pretty sure since there where no deprecation changes between 2.7 and 2.8. The helpers in Extbase ConsoleOutput are already silenced to not throw deprecation warnings, which will keep working in 2.8. See http://symfony.com/blog/symfony-2-8-0-released > This is minor update in our dependencies which will enventually be > released as bugfix TYPO3 release. imho this does not fit well I am aware of this policy in general but please keep in mind that TYPO3 7.6 is here to stay for the next years. Without this change it is impossible to use Symfony 2.8 components with TYPO3, thus one is forced to upgrade to TYPO3 8.x or fiddle around with version aliases which are bound to break in other ways.
  5. Mathias Brodala uploaded patch set 2 06/20/16, 10:27

  6. Mathias Brodala commented on patch set 2 06/20/16, 10:27

    Rebased to master, switched to caret operator (same result in this case)
  7. Mathias Brodala updated the commit message in patch set 3 06/20/16, 10:30

  8. Helmut Hummel commented on patch set 3 CR -1 06/20/16, 11:20

    @Mathias: can you confirm that console 2.8.x does not introduce additional deprecation messages to be thrown by the code TYPO3 uses? Are there any other incompatibilities we may run into?
  9. Mathias Brodala commented on patch set 3 06/20/16, 11:32

    > @Mathias: can you confirm that console 2.8.x does not introduce > additional deprecation messages to be thrown by the code TYPO3 > uses? > > Are there any other incompatibilities we may run into? I can see nothing for Console in the upgrade guid: https://github.com/symfony/symfony/blob/v2.8.0/UPGRADE-2.8.md Here's the exact list of changes between 2.7 and 2.8: https://github.com/symfony/console/compare/2.7...2.8 Noticeable changes here are the kind of exceptions thrown starting with 2.8, but AFAIS all of the new exception types extend the previous ones, thus catch clauses will continue to work.
  10. Mathias Brodala uploaded patch set 4 09/29/16, 13:27

  11. TYPO3com voted on patch set 4 V +1 09/29/16, 13:29 Completed build in 01m 48s on Thu, 29 Sep, 03:29 PM Test Summary: 34910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-133

  12. Stefan Neufeind uploaded patch set 5 11/23/16, 12:46

  13. TYPO3com voted on patch set 5 V +1 11/23/16, 12:50 Completed build in 03m 21s on Wed, 23 Nov, 01:50 PM Test Summary: 38266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-430

  14. Jakob Berlin voted on patch set 5 CR +1 V +1 11/23/16, 12:58

  15. Helmut Hummel commented on patch set 5 CR -1 11/23/16, 13:00

    wait a bit please and let me check
  16. Helmut Hummel uploaded patch set 6 11/23/16, 13:05

  17. Helmut Hummel commented on patch set 6 11/23/16, 13:06

    The new lock file reflects the dependency changes also for our builds
  18. TYPO3com voted on patch set 6 V +1 11/23/16, 13:09 Completed build in 03m 30s on Wed, 23 Nov, 02:09 PM Test Summary: 38266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-431

  19. Stefan Neufeind commented on patch set 6 CR +1 V +1 11/23/16, 13:14

    Thanks for the update, Helmut. I updated the lock with "composer update --lock", which obviously wasn't fully sufficient. Checked that with this patch it now pulls in versions 2.8.x fine (not 3.0).
  20. Peter Foerger voted on patch set 6 CR +1 V +1 11/23/16, 13:29

  21. Helmut Hummel voted on patch set 6 CR +2 V +2 11/23/16, 13:58

  22. Gerrit merged patch set 6 11/23/16, 13:58

  23. Michael Stucki commented on patch set 7 11/24/16, 15:31

    What will happen next with this patch? It's a regression in TYPO3 7.6.13 so it should be fixed rather soon. At least, a little info on the Wiki page would be helpful... Can you do that please? Let me know if I can help...
  24. Helmut Hummel commented on patch set 7 11/24/16, 20:31

    the idea is to release 7.6.14 pretty soon
  25. Michael Stucki commented on patch set 7 11/29/16, 14:32

    Thank you!