48066[BUGFIX] Filter out space char on client-side from alpha/num/alphanum/alphanum_x fields
Commit message
Review
-
Code review CR +2
- Tymoteusz Motylewski +2
- Christian Kuhn +1
-
Verified V +2
- Tymoteusz Motylewski +2
- Christian Kuhn +1
Issues 1
Files 3
Review log 10
-
Nikola Stojiljković uploaded patch set 1 05/10/16, 14:24
-
Nikola Stojiljković uploaded patch set 2 05/10/16, 14:31
-
Markus Klein commented on patch set 2 05/10/16, 14:33
I'm not sure what the title of the commit has to do with the code? You remove code. Can you explain the change in the commit message please? -
Nikola Stojiljković uploaded patch set 3 05/10/16, 14:35
-
Christian Kuhn commented on patch set 3 05/10/16, 15:03
+1 on testing the solution, but this fix introduces acceptance test fails. you do fix those with a further patch, but the acceptance test fixes for these fields should be included in the patch here. -
Nikola Stojiljković uploaded patch set 4 05/10/16, 15:04
-
Christian Kuhn voted on patch set 4 CR +1 V +1 05/10/16, 15:07
-
Tymoteusz Motylewski voted on patch set 4 CR +1 V +1 05/10/16, 15:13
-
Tymoteusz Motylewski voted on patch set 4 CR +2 V +2 05/10/16, 15:23
-
Gerrit merged patch set 4 05/10/16, 15:23