Review main Merged

48066[BUGFIX] Filter out space char on client-side from alpha/num/alphanum/alphanum_x fields

Nikola Stojiljković CR +2 V +2 Easy +4 −4 updated 05/10/16, 15:23

Commit message

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 10

  1. Nikola Stojiljković uploaded patch set 1 05/10/16, 14:24

  2. Nikola Stojiljković uploaded patch set 2 05/10/16, 14:31

  3. Markus Klein commented on patch set 2 05/10/16, 14:33

    I'm not sure what the title of the commit has to do with the code? You remove code. Can you explain the change in the commit message please?
  4. Nikola Stojiljković uploaded patch set 3 05/10/16, 14:35

  5. Christian Kuhn commented on patch set 3 05/10/16, 15:03

    +1 on testing the solution, but this fix introduces acceptance test fails. you do fix those with a further patch, but the acceptance test fixes for these fields should be included in the patch here.
  6. Nikola Stojiljković uploaded patch set 4 05/10/16, 15:04

  7. Christian Kuhn voted on patch set 4 CR +1 V +1 05/10/16, 15:07

  8. Tymoteusz Motylewski voted on patch set 4 CR +1 V +1 05/10/16, 15:13

  9. Tymoteusz Motylewski voted on patch set 4 CR +2 V +2 05/10/16, 15:23

  10. Gerrit merged patch set 4 05/10/16, 15:23