Review main Merged

48067[BUGFIX] Prevent validation from altering the field value

Nikola Stojiljković CR +2 V +2 Easy +6 −3 updated 05/11/16, 18:40

Commit message

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 10

  1. Nikola Stojiljković uploaded patch set 1 05/10/16, 14:31

  2. Nikola Stojiljković uploaded patch set 2 05/10/16, 14:35

  3. Markus Klein voted on patch set 2 CR +1 05/10/16, 14:37

  4. Nikola Stojiljković rebased onto patch set 3 05/10/16, 15:04

  5. Christian Kuhn voted on patch set 3 CR +1 V +1 05/10/16, 15:23

  6. Tymoteusz Motylewski voted on patch set 3 CR +2 V +2 05/10/16, 15:30

  7. Gerrit merged patch set 3 05/10/16, 15:30

  8. Nicole Hummel commented on patch set 4 05/11/16, 18:27

    Post -1 This patch breaks using the Element Browser in Chrome, because an error occurs: Uncaught TypeError: Cannot read property 'length' of null
  9. Nicole Hummel commented on patch set 4 05/11/16, 18:28

    This error seems to only occur in Chrome
  10. Nicole Hummel commented on patch set 4 05/11/16, 18:40

    FormEngineValidation.js:252

    This function returns a string even if the value is null. Now the return of the whole function is changed. I will push a follow-up