48070[BUGFIX] Raise hostname length to 255 characters
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Tomita Militaru +1
- Adrian Mot +1
- Morton Jonuschat +1
-
Verified V +2
- Wouter Wolters +2
- Morton Jonuschat +1
Issues 1
Files 1
Review log 14
-
Anja Leichsenring uploaded patch set 1 05/11/16, 08:13
-
Morton Jonuschat voted on patch set 1 CR +1 V +1 05/11/16, 08:19
-
Morton Jonuschat commented on patch set 1 05/11/16, 08:20
I'm fine with spelling out the length restriction but it might be easier to understand if we just write 255. -
Tomita Militaru voted on patch set 1 CR +1 05/11/16, 08:22
-
Anja Leichsenring commented on patch set 1 05/11/16, 08:26
testing currently, will change the spelling. Morton is right here. -
Adrian Mot commented on patch set 1 CR +1 05/11/16, 08:36
I am also for spelling "255" as a number. -
Anja Leichsenring uploaded patch set 2 05/11/16, 08:40
-
Morton Jonuschat voted on patch set 2 CR +1 V +1 05/11/16, 08:41
-
Tomita Militaru voted on patch set 2 CR +1 05/11/16, 08:41
-
Wouter Wolters voted on patch set 2 CR +1 05/11/16, 08:41
-
Adrian Mot voted on patch set 2 CR +1 05/11/16, 08:44
-
Morton Jonuschat commented on patch set 2 05/11/16, 09:29
This is totally easy to test with an entry in /etc/hosts btw -
Wouter Wolters voted on patch set 2 CR +2 V +2 05/11/16, 18:38
-
Gerrit merged patch set 2 05/11/16, 18:38