Review main Merged

48070[BUGFIX] Raise hostname length to 255 characters

Anja Leichsenring CR +2 V +2 Easy +2 −2 updated 05/11/16, 18:38

Commit message

When installing TYPO3 in a cloud environment, the 50 character
limit is not high enough. Therefor it is raised to 255 chars,
what most protocols define as the max limit.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Tomita Militaru +1
    • Adrian Mot +1
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 14

  1. Anja Leichsenring uploaded patch set 1 05/11/16, 08:13

  2. Morton Jonuschat voted on patch set 1 CR +1 V +1 05/11/16, 08:19

  3. Morton Jonuschat commented on patch set 1 05/11/16, 08:20

    I'm fine with spelling out the length restriction but it might be easier to understand if we just write 255.
  4. Tomita Militaru voted on patch set 1 CR +1 05/11/16, 08:22

  5. Anja Leichsenring commented on patch set 1 05/11/16, 08:26

    testing currently, will change the spelling. Morton is right here.
  6. Adrian Mot commented on patch set 1 CR +1 05/11/16, 08:36

    I am also for spelling "255" as a number.
  7. Anja Leichsenring uploaded patch set 2 05/11/16, 08:40

  8. Morton Jonuschat voted on patch set 2 CR +1 V +1 05/11/16, 08:41

  9. Tomita Militaru voted on patch set 2 CR +1 05/11/16, 08:41

  10. Wouter Wolters voted on patch set 2 CR +1 05/11/16, 08:41

  11. Adrian Mot voted on patch set 2 CR +1 05/11/16, 08:44

  12. Morton Jonuschat commented on patch set 2 05/11/16, 09:29

    This is totally easy to test with an entry in /etc/hosts btw
  13. Wouter Wolters voted on patch set 2 CR +2 V +2 05/11/16, 18:38

  14. Gerrit merged patch set 2 05/11/16, 18:38