Review main Merged

48071[BUGFIX] Add hideAtCopy and prependAtCopy for pages_language_overlay

Zbigniew Jacko CR +2 V +2 Easy +4 −1 updated 11/29/16, 09:44

Commit message

When a pages_language_overlay record is copied it will be hidden
and it's name will change to 'oldName (copy n)'.
And adding a default value for shortcut column. (mysql 5.7 and strict mode)

Review

  • Code review CR +2
    • Frank Nägler +2
    • Jörg Bösche +1
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Jörg Bösche +1
    • Susi Moog +1

Issues 1

Files 1

Review log 9

  1. Zbigniew Jacko uploaded patch set 1 05/11/16, 09:24

  2. Anja Leichsenring updated the commit message in patch set 2 05/11/16, 12:58

  3. Jörg Bösche uploaded patch set 3 06/07/16, 09:25

  4. Susi Moog voted on patch set 3 CR +1 V +1 06/07/16, 09:29

  5. Jörg Bösche voted on patch set 3 CR +1 V +1 06/12/16, 12:59

  6. Frank Nägler voted on patch set 3 CR +1 06/13/16, 09:41

  7. Frank Nägler voted on patch set 3 CR +2 V +2 06/13/16, 10:06

  8. Gerrit merged patch set 3 06/13/16, 10:07

  9. Christian Toffolo commented on patch set 4 11/29/16, 09:44

    This patch works only if the copy is made directly copying a 'pages_language_overlay' record in the List module. Instead the bug report (https://forge.typo3.org/issues/76038) that this patch should solve states that the problem is when a BE user copies a 'pages' record and this is the real useful case of adding a "(copy n)" to language overlays.