Review TYPO3_6-2 Abandoned

48076[BUGFIX] Remove composer evaluation for dependencies/suggestions

Mathias Brodala CR 0 V 0 Normal +65 −10 updated 12/09/16, 08:47

Commit message

Currently in 6.2, if an extension author defined a composer.json
then dependencies, version or suggestions were taken from there,
instead of using ext_emconf.php.

The evaluation is removed. To ensure the "core" extension is still
loaded before all other system extensions, this dependency is added
to the ext_emconf.php.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 56

Show 36 more files

Review log 5

  1. Mathias Brodala uploaded patch set 1 05/11/16, 12:10

  2. Mathias Brodala commented on patch set 1 05/11/16, 12:21

    If you want to integrate this change in a Composer-based setup, you can use the package "cweagans/composer-patches" and the patch URL found via gitweb here.
  3. Anja Leichsenring commented on patch set 1 12/08/16, 18:53

    Sorry, no fiddeling with the composer behavior of old stable branch. This patch will not make it. Please abandon.
  4. Wouter Wolters abandoned the change 12/08/16, 20:07

    Updated by Nicole Cordes 28 days ago Status changed from Under Review to Rejected Comment Meanwhile there are updated versions of the extensions, compatible with 7.6. I don't see any reason to change the current composer behaviour in 6.2. IMHO there would be more trouble with such a patch. Therefore I decided to reject this ticket.
  5. Mathias Brodala commented on patch set 1 12/09/16, 08:47

    The patch works perfectly fine on 6.2 installations (used in production). I mostly posted it to have a patch URL which can be used with cweagans/composer-patches, thus as long as Gerrit keeps it, I'm fine. ;-)