Review main Merged

48091[TASK] Deprecated methods in unit tests

Adrian Mot CR +2 V +2 Hard +393 −174 updated 05/16/16, 11:43

Commit message

- Use expectedException() and expectedExceptionCode() instead of
  deprecated setExpectedException()
- Fix a couple of incomplete tests in core/Http section, add some
  and slightly refactor a bit

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Adrian Mot +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Adrian Mot +1
    • Christian Kuhn +1

Issues 1

Files 46

Show 26 more files

Review log 10

  1. Adrian Mot uploaded patch set 1 05/12/16, 08:33

  2. Anja Leichsenring commented on patch set 1 CR -1 05/12/16, 09:41

    I would rather have exception codes tested than messages. Can you please do that? Thanks.

    AbstractFormProtectionTest.php:86

    please find out the exception code of this exception and use it for explicit test

    MessageTest.php:207

    please find out the exception code for explicit testing, the wording of the message might change over time, code never. Please do this for all occurences.
  3. Christian Kuhn commented on patch set 1 CR -1 05/12/16, 11:59

    adrian is still working on it.
  4. Adrian Mot uploaded patch set 2 05/12/16, 20:32

  5. Christian Kuhn uploaded patch set 3 05/14/16, 10:53

  6. Christian Kuhn commented on patch set 2 05/14/16, 10:54

    UriTest.php:134

    this one fails. i now removed boolean true test here and added a test with a @todo explaining this, so this could be adapted later if wanted.
  7. Christian Kuhn commented on patch set 3 CR +1 V +1 05/14/16, 10:56

    good job, thank you! I only applied minor whitespace changes, changed the commit message a bit, and fixed the UriTest port thing by adding a specific test showing the funny behavior and explaining in an @todo on what is funny there. This way we can pick it up later if wanted.
  8. Adrian Mot voted on patch set 3 CR +1 V +1 05/16/16, 09:42

  9. Wouter Wolters voted on patch set 3 CR +2 V +2 05/16/16, 11:43

  10. Gerrit merged patch set 3 05/16/16, 11:43