48091[TASK] Deprecated methods in unit tests
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Adrian Mot +1
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Adrian Mot +1
- Christian Kuhn +1
Issues 1
Files 46
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/FlexFormSegmentTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/InlineParentRecordTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/OnTheFlyTest.php+4 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaDatabaseRecordTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaInputPlaceholderRecordTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php+10 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabasePageLanguageOverlayRowsTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRecordTypeValueTest.php+10 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseSystemLanguageRowsTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUniqueUidNewRowTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUserPermissionCheckTest.php+18 −9
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/InitializeProcessedTcaTest.php+6 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+4 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessShowitemTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexFetchTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexPrepareTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexProcessTest.php+8 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaGroupTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php+20 −10
Show 26 more files
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php+8 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRecordTitleTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+6 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataCompilerTest.php+16 −8
- typo3/sysext/core/Tests/Unit/FormProtection/AbstractFormProtectionTest.php1+2 −1
- typo3/sysext/core/Tests/Unit/Http/MessageTest.php1+8 −5
- typo3/sysext/core/Tests/Unit/Http/RequestTest.php+21 −8
- typo3/sysext/core/Tests/Unit/Http/ResponseTest.php+7 −5
- typo3/sysext/core/Tests/Unit/Http/StreamTest.php+22 −8
- typo3/sysext/core/Tests/Unit/Http/UploadedFileTest.php+15 −8
- typo3/sysext/core/Tests/Unit/Http/UriTest.php1+86 −15
- typo3/sysext/core/Tests/Unit/Imaging/IconFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Driver/DriverRegistryTest.php+6 −3
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+19 −10
- typo3/sysext/core/Tests/Unit/Resource/Repository/AbstractRepositoryTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+6 −3
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/TreeDataProviderFactoryTest.php+2 −1
- typo3/sysext/core/Tests/Unit/TypoScript/Parser/TypoScriptParserTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/VersionNumberUtilityTest.php+2 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AbstractCompositeValidatorTest.php+9 −6
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AbstractValidatorTest.php+9 −6
- typo3/sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php+12 −5
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php+14 −6
- typo3/sysext/fluid/Tests/Unit/Core/ViewHelper/AbstractViewHelperTest.php+2 −2
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+9 −9
Review log 10
-
Adrian Mot uploaded patch set 1 05/12/16, 08:33
-
Anja Leichsenring commented on patch set 1 CR -1 05/12/16, 09:41
I would rather have exception codes tested than messages. Can you please do that? Thanks.AbstractFormProtectionTest.php:86please find out the exception code of this exception and use it for explicit testMessageTest.php:207please find out the exception code for explicit testing, the wording of the message might change over time, code never. Please do this for all occurences. -
Christian Kuhn commented on patch set 1 CR -1 05/12/16, 11:59
adrian is still working on it. -
Adrian Mot uploaded patch set 2 05/12/16, 20:32
-
Christian Kuhn uploaded patch set 3 05/14/16, 10:53
-
Christian Kuhn commented on patch set 2 05/14/16, 10:54
UriTest.php:134this one fails. i now removed boolean true test here and added a test with a @todo explaining this, so this could be adapted later if wanted. -
Christian Kuhn commented on patch set 3 CR +1 V +1 05/14/16, 10:56
good job, thank you! I only applied minor whitespace changes, changed the commit message a bit, and fixed the UriTest port thing by adding a specific test showing the funny behavior and explaining in an @todo on what is funny there. This way we can pick it up later if wanted. -
Adrian Mot voted on patch set 3 CR +1 V +1 05/16/16, 09:42
-
Wouter Wolters voted on patch set 3 CR +2 V +2 05/16/16, 11:43
-
Gerrit merged patch set 3 05/16/16, 11:43