48102[TASK] Deprecate RemoveXSS
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Nicole Hummel +1
-
Verified V +2
- Wouter Wolters +2
- Nicole Hummel +1
Issues 1
Files 21
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+1 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php3+10 −4
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-76164-DeprecateRemoveXSS.rst2new+30 −0
- typo3/sysext/core/Resources/PHP/RemoveXSS.php+9 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+3 −1
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php2+7 −10
- typo3/sysext/felogin/Resources/Private/Language/locallang.xlf+0 −3
- typo3/sysext/form/Classes/Domain/Builder/FormBuilder.php+0 −2
- typo3/sysext/form/Classes/Domain/Filter/RemoveXssFilter.php4+3 −0
- typo3/sysext/form/Configuration/PageTS/modWizards.ts+1 −5
- typo3/sysext/form/Configuration/TypoScript/Filters/Filters.ts+0 −5
- typo3/sysext/form/Documentation/Administration/WizardSettings/DefaultsReference/OptionsTab/Index.rst+2 −5
- typo3/sysext/form/Documentation/Configuration/Filters/Removexss/Index.rstdeleted+0 −16
- typo3/sysext/form/Documentation/Configuration/Filters/Index.rst+0 −6
- typo3/sysext/form/Documentation/Configuration/Objects/ObjectAttributes/Index.rst2+1 −4
- typo3/sysext/form/Resources/Private/Language/locallang_wizard.xlf+0 −3
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Filters/RemoveXSS.jsdeleted+0 −18
- typo3/sysext/form/Resources/Public/JavaScript/Wizard/Viewport/Left/Options/Forms/Filters.js+0 −2
- typo3/sysext/form/Resources/Public/JavaScript/Wizard.js+0 −2
Review log 38
Show 13 earlier messages
-
Georg Ringer uploaded patch set 1 05/12/16, 13:05
-
Mathias Brodala updated the commit message in patch set 2 05/12/16, 13:16
-
Mathias Brodala commented on patch set 2 05/12/16, 13:16
FrontendLoginController.php:1011Can we drop this now unused translation, too? -
Daniel Goerz uploaded patch set 3 05/12/16, 15:50
-
Daniel Goerz voted on patch set 3 CR +1 05/12/16, 15:51
-
Helmut Hummel uploaded patch set 4 05/18/16, 11:28
-
Helmut Hummel commented on patch set 4 05/18/16, 11:28
Removed the XSS Filter from ts configuration as well -
Markus Klein updated the commit message in patch set 5 05/18/16, 11:32
-
Oliver Klee commented on patch set 4 05/18/16, 11:34
RemoveXssFilter.php:38Should we have a deprecation log entry here? -
Markus Klein commented on patch set 6 05/18/16, 11:34
Published edit on patch set 5. -
Helmut Hummel uploaded patch set 7 05/18/16, 11:35
-
Markus Klein commented on patch set 8 05/18/16, 11:36
Published edit on patch set 7. -
Helmut Hummel commented on patch set 6 05/18/16, 11:37
GeneralUtility.php:256uhm, no. the deprecation is logged already in \RemoveXSS::processDeprecation-76164-DeprecateRemoveXSS.rst:10I'll fix this in a new patch set again
-
Helmut Hummel uploaded patch set 9 05/18/16, 11:38
-
Helmut Hummel commented on patch set 4 05/18/16, 11:39
RemoveXssFilter.php:38Replydeprecation will be logged in the final static method which is beeing called. adding a messgage here will result in duplicate messages for one usage -
Markus Klein commented on patch set 8 05/18/16, 11:40
GeneralUtility.php:256missing deprecation logRemoveXssFilter.php:38deprecation log missing -
Markus Klein commented on patch set 8 05/18/16, 11:40
RemoveXssFilter.php:38Replyforget it, obsolete! -
Markus Klein commented on patch set 6 05/18/16, 11:42
GeneralUtility.php:256ReplyQuestion is whether we still should log the usage of this function too? -
Helmut Hummel updated the commit message in patch set 10 05/18/16, 11:43
-
Markus Klein voted on patch set 10 CR +1 05/18/16, 11:45
-
Markus Klein voted on patch set 10 V +1 05/18/16, 11:51
-
Nicole Hummel commented on patch set 10 05/18/16, 11:51
Index.rst:369This has to be changed as well. -
Helmut Hummel uploaded patch set 11 05/18/16, 12:02
-
Helmut Hummel commented on patch set 10 05/18/16, 12:02
Index.rst:369Replygood catch -
Nicole Hummel commented on patch set 11 V -1 05/18/16, 12:09
There were 5 failures: 1) TYPO3\CMS\Core\Tests\Unit\Utility\GeneralUtilityTest::sanitizeLocalUrlDeniesPlainInvalidUrls with data set "relative path with XSS" ('../typo3/whatever.php?argumen...ert(0)') Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'' +'../typo3/whatever.php?argument=javascript:alert(0)' D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Unit\Utility\GeneralUtilityTest.php:2202 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\vendor\phpunit\phpunit\phpunit:47 2) TYPO3\CMS\Core\Tests\Unit\Utility\GeneralUtilityTest::sanitizeLocalUrlDeniesEncodedInvalidUrls with data set "relative path with XSS" ('../typo3/whatever.php?argumen...ert(0)') Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'' +'..%2Ftypo3%2Fwhatever.php%3Fargument%3Djavascript%3Aalert%280%29' D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\core\Tests\Unit\Utility\GeneralUtilityTest.php:2211 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\vendor\phpunit\phpunit\phpunit:47 3) TYPO3\CMS\Felogin\Tests\Unit\Controller\FrontendLoginControllerTest::validateRedirectUrlClearsUrl with data set "XSS attempt 2" ('" onmouseover="alert(123)"') Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'' +'" onmouseover="alert(123)"' D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\felogin\tests\Unit\Controller\FrontendLoginControllerTest.php:182 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\vendor\phpunit\phpunit\phpunit:47 4) TYPO3\CMS\Felogin\Tests\Unit\Controller\FrontendLoginControllerTest::validateRedirectUrlClearsUrl with data set "invalid URL, HTML break out attempt" ('" >blabuubb') Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'' +'" >blabuubb' D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\felogin\tests\Unit\Controller\FrontendLoginControllerTest.php:182 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\vendor\phpunit\phpunit\phpunit:47 5) TYPO3\CMS\Felogin\Tests\Unit\Controller\FrontendLoginControllerTest::validateRedirectUrlClearsUrl with data set "invalid URL, UNC path" ('\\foo\bar\') Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'' +'\\foo\bar\' D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\felogin\tests\Unit\Controller\FrontendLoginControllerTest.php:182 D:\Version Control\Git\TYPO3\TYPO3.CMS\master\vendor\phpunit\phpunit\phpunit:47 -
Nicole Hummel commented on patch set 11 05/18/16, 12:10
Anyone working on the unit test issues? Otherwise I can try to push a new patch set this evening. -
Markus Klein commented on patch set 11 05/18/16, 12:31
? I ran the unittests on master and all were green -
Markus Klein commented on patch set 11 05/18/16, 12:32
Whatever I did wrong, sorry for my v+1 before then. -
Helmut Hummel commented on patch set 11 V -1 05/18/16, 12:43
I can confirm the test failures. thanks! -
Nicole Hummel uploaded patch set 12 05/20/16, 17:07
-
Nicole Hummel uploaded patch set 13 05/20/16, 17:07
-
Elmar Hinz uploaded patch set 14 05/22/16, 07:27
-
Markus Klein voted on patch set 14 CR +1 05/22/16, 08:04
-
Wouter Wolters commented on patch set 14 CR -1 05/26/16, 12:16
2 failing test, on itDeprecation-76164-DeprecateRemoveXSS.rst:30space after chars`` -
Wouter Wolters uploaded patch set 15 05/26/16, 12:17
-
Nicole Hummel commented on patch set 15 CR +1 V +1 05/26/16, 13:06
Verified by running unit and functional tests. -
Wouter Wolters voted on patch set 15 CR +2 V +2 05/26/16, 13:52
-
Gerrit merged patch set 15 05/26/16, 13:52
FrontendLoginController.php:1011