Review main Merged

48132[TASK] Optimise comment of $sortedConf in the stdWrap function

Elmar Hinz CR +2 V +2 Easy +1 −2 updated 05/27/16, 10:59

Commit message

Explain the creation and name of the variable in concise words.

Review

  • Code review CR +2
    • Markus Klein +2
    • Olaf Schmidt-Wischhöfer +1
  • Verified V +2
    • Markus Klein +2
    • Olaf Schmidt-Wischhöfer +1

Issues 2

Files 1

Review log 12

  1. Elmar Hinz uploaded patch set 1 05/14/16, 09:22

  2. Elmar Hinz abandoned the change 05/14/16, 09:27

  3. Elmar Hinz restored the change 05/14/16, 09:54

  4. Elmar Hinz uploaded patch set 2 05/14/16, 09:54

  5. Markus Klein updated the commit message in patch set 3 05/14/16, 11:39

  6. Markus Klein voted on patch set 3 CR +1 V +1 05/14/16, 11:39

  7. Olaf Schmidt-Wischhöfer commented on patch set 3 05/17/16, 09:36

    ContentObjectRenderer.php:2006

    I suggest you make this “sorted and filtered”: The configuration is both sorted and filtered.
  8. Elmar Hinz commented on patch set 4 05/22/16, 08:01

    Published edit on patch set 3.
  9. Elmar Hinz updated the commit message in patch set 5 05/22/16, 09:53

  10. Olaf Schmidt-Wischhöfer commented on patch set 5 CR +1 V +1 05/23/16, 07:24

    Thank you.
  11. Markus Klein voted on patch set 5 CR +2 V +2 05/27/16, 10:59

  12. Gerrit merged patch set 5 05/27/16, 10:59