Review main Merged

48181[BUGFIX] Correctly treat uploaded file when replacing a file

Markus Klein CR +2 V +2 Easy +5 −1 updated 05/17/16, 11:26

Commit message

Uploaded files must be moved with the specific PHP function,
otherwise permissions may be wrong.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Frans Saris +1
    • Andreas Kienast +1
    • Nicole Hummel +1
  • Verified V +2
    • Oliver Hader +2
    • Frans Saris +1

Issues 1

Files 1

Review log 13

  1. Markus Klein uploaded patch set 1 05/17/16, 08:38

  2. Andreas Kienast voted on patch set 1 CR +1 05/17/16, 08:44

  3. Frans Saris voted on patch set 1 CR +1 05/17/16, 08:44

  4. Markus Klein commented on patch set 1 05/17/16, 08:50

    btw. This code is no invention from my side, but just c&p from the addFile() method.
  5. Markus Klein commented on patch set 1 05/17/16, 08:50

    The fix is already running on the live servers now.
  6. Frans Saris commented on patch set 1 05/17/16, 08:51

    testing now
  7. Frans Saris voted on patch set 1 V +1 05/17/16, 08:54

  8. Nicole Hummel voted on patch set 1 CR +1 05/17/16, 09:06

  9. Oliver Hader commented on patch set 1 CR +1 05/17/16, 10:28

    Looks reasonable by comparing with addFile() method - however not tested
  10. Oliver Hader voted on patch set 1 V +1 05/17/16, 11:24

  11. Oliver Hader commented on patch set 1 05/17/16, 11:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 697b3f0816633d3bdddfd74108cba74cb9b7909a
  12. Oliver Hader voted on patch set 1 CR +2 V +2 05/17/16, 11:26

  13. Gerrit merged patch set 1 05/17/16, 11:26