48185[FEATURE] Introduce hook for custom result browser implementations
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Markus Klein +1
-
Verified V +2
- Georg Ringer +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Feature-76209-HookToRegisterCustomResultBrowsersInAbstractPlugin.rstnew+32 −0
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php2+14 −1
- typo3/sysext/frontend/Tests/Unit/Fixtures/ResultBrowserPluginHook.phpnew+38 −0
- typo3/sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php+90 −3
Review log 1621
-
Andreas Kienast uploaded patch set 1 05/17/16, 10:14
-
Mathias Brodala commented on patch set 1 05/17/16, 10:18
Why not use AbstractPlugin here? It's already hard enough to map the old hooks to the current class names. ;-) -
Andreas Kienast commented on patch set 1 05/17/16, 10:21
You're right, gimme a sec, please -
Andreas Kienast uploaded patch set 2 05/17/16, 10:24
-
Andreas Kienast uploaded patch set 3 05/17/16, 10:36
-
Andreas Kienast uploaded patch set 4 05/17/16, 10:38
-
Andreas Kienast uploaded patch set 5 05/17/16, 10:42
-
Andreas Kienast uploaded patch set 6 07/23/16, 08:18
-
TYPO3com voted on patch set 6 V -1 07/23/16, 08:23 Completed build in 05m 10s on Sat, 23 Jul, 10:23 AM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1319
-
Andreas Kienast uploaded patch set 7 07/23/16, 09:42
-
TYPO3com voted on patch set 7 V -1 07/23/16, 09:48 Completed build in 05m 33s on Sat, 23 Jul, 11:48 AM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1324
-
Andreas Kienast uploaded patch set 8 07/23/16, 09:58
-
TYPO3com voted on patch set 8 V +1 07/23/16, 10:04 Completed build in 05m 48s on Sat, 23 Jul, 12:04 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1325
-
Andreas Kienast uploaded patch set 9 07/23/16, 11:59
-
TYPO3com voted on patch set 9 V +1 07/23/16, 12:03 Completed build in 04m 34s on Sat, 23 Jul, 02:03 PM Test Summary: 19374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1330
-
Markus Klein commented on patch set 9 07/23/16, 13:34
AbstractPlugin.php:517Please do not use getUserObj anymore!AbstractPlugin.php:518IMO we should have a check if the function exists in the hookobj -
Andreas Kienast uploaded patch set 10 07/23/16, 13:40
-
TYPO3com voted on patch set 10 V +1 07/23/16, 13:45 Completed build in 04m 47s on Sat, 23 Jul, 03:45 PM Test Summary: 19374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1331
-
Markus Klein voted on patch set 10 CR +1 V +1 07/23/16, 14:14
-
Georg Ringer voted on patch set 10 CR +2 V +2 07/23/16, 14:32
-
Gerrit merged patch set 10 07/23/16, 14:32