Review main Merged

48185[FEATURE] Introduce hook for custom result browser implementations

Andreas Kienast CR +2 V +2 Normal +174 −4 updated 07/23/16, 14:32

Commit message

The hook ``[\TYPO3\CMS\Frontend\Plugin\AbstractPlugin::class]['pi_list_browseresults']``
may be used to register a custom result browser implementation without the
need to override the method ``AbstractPlugin::pi_list_browseresults`` in
each pi-based plugin.
This is helpful if an implementation should be used for either all or
specific plugins.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1621

  1. Andreas Kienast uploaded patch set 1 05/17/16, 10:14

  2. Mathias Brodala commented on patch set 1 05/17/16, 10:18

    Why not use AbstractPlugin here? It's already hard enough to map the old hooks to the current class names. ;-)
  3. Andreas Kienast commented on patch set 1 05/17/16, 10:21

    You're right, gimme a sec, please
  4. Andreas Kienast uploaded patch set 2 05/17/16, 10:24

  5. Andreas Kienast uploaded patch set 3 05/17/16, 10:36

  6. Andreas Kienast uploaded patch set 4 05/17/16, 10:38

  7. Andreas Kienast uploaded patch set 5 05/17/16, 10:42

  8. Andreas Kienast uploaded patch set 6 07/23/16, 08:18

  9. TYPO3com voted on patch set 6 V -1 07/23/16, 08:23 Completed build in 05m 10s on Sat, 23 Jul, 10:23 AM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1319

  10. Andreas Kienast uploaded patch set 7 07/23/16, 09:42

  11. TYPO3com voted on patch set 7 V -1 07/23/16, 09:48 Completed build in 05m 33s on Sat, 23 Jul, 11:48 AM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1324

  12. Andreas Kienast uploaded patch set 8 07/23/16, 09:58

  13. TYPO3com voted on patch set 8 V +1 07/23/16, 10:04 Completed build in 05m 48s on Sat, 23 Jul, 12:04 PM Test Summary: 19372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1325

  14. Andreas Kienast uploaded patch set 9 07/23/16, 11:59

  15. TYPO3com voted on patch set 9 V +1 07/23/16, 12:03 Completed build in 04m 34s on Sat, 23 Jul, 02:03 PM Test Summary: 19374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1330

  16. Markus Klein commented on patch set 9 07/23/16, 13:34

    AbstractPlugin.php:517

    Please do not use getUserObj anymore!

    AbstractPlugin.php:518

    IMO we should have a check if the function exists in the hookobj
  17. Andreas Kienast uploaded patch set 10 07/23/16, 13:40

  18. TYPO3com voted on patch set 10 V +1 07/23/16, 13:45 Completed build in 04m 47s on Sat, 23 Jul, 03:45 PM Test Summary: 19374 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1331

  19. Markus Klein voted on patch set 10 CR +1 V +1 07/23/16, 14:14

  20. Georg Ringer voted on patch set 10 CR +2 V +2 07/23/16, 14:32

  21. Gerrit merged patch set 10 07/23/16, 14:32