Review main Merged

48192[TASK] Optimize FormEngineValidation, Part II

Andreas Kienast CR +2 V +2 Easy +11 −7 updated 11/23/17, 08:13

Commit message

Some functions inside FormEngineValidation are optimized to reduce
runtime or run multiple validations on fields that are already
marked as "failed".

Review

  • Code review CR +2
    • Jan Helke +2
    • Frank Nägler +1
  • Verified V +2
    • Jan Helke +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1216

  1. Andreas Kienast uploaded patch set 1 05/17/16, 11:05

  2. Andreas Kienast uploaded patch set 2 05/18/16, 14:34

  3. Andreas Kienast uploaded patch set 3 05/18/16, 14:43

  4. Andreas Kienast uploaded patch set 4 04/27/17, 17:58

  5. TYPO3com voted on patch set 4 V -1 04/27/17, 18:04 Completed build in 05m 55s on Thu, 27 Apr, 08:04 PM Test Summary: 1 of 55785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11057

  6. Andreas Kienast uploaded patch set 5 04/27/17, 18:09

  7. TYPO3com voted on patch set 5 V +1 04/27/17, 18:14 Completed build in 05m 06s on Thu, 27 Apr, 08:14 PM Test Summary: 55782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11060

  8. Wolfgang Klinger commented on patch set 5 CR -1 07/14/17, 09:57

    FormEngineValidation.js:425

    Characters in config.is_in are not escaped for a regular expression here! This might lead to a javascript error (Invalid regular expression) if is_in includes certain characters (like a backslash or quotes)
  9. Andreas Kienast uploaded patch set 6 10/01/17, 10:45

  10. Andreas Kienast commented on patch set 5 10/01/17, 10:46

    FormEngineValidation.js:425 Reply

    Please elaborate (or even better: push a new set) how to fix this issue. I can't find anything here, every example I found is like this code.
  11. TYPO3com voted on patch set 6 V +1 10/01/17, 10:58 Completed build in 12m 28s on Sun, 1 Oct, 12:58 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15232

  12. Andreas Kienast uploaded patch set 7 11/14/17, 14:19

  13. TYPO3com voted on patch set 7 V +1 11/14/17, 14:31 Completed build in 11m 36s on Tue, 14 Nov, 03:31 PM Test Summary: 56768 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16333

  14. Frank Nägler voted on patch set 7 CR +1 V +1 11/22/17, 13:08

  15. Jan Helke voted on patch set 7 CR +2 V +2 11/23/17, 08:13

  16. Gerrit merged patch set 7 11/23/17, 08:13