Review main Merged

48195[BUGFIX] Ensure correct return type for AbstractFile getters

Markus Klein CR +2 V +2 Easy +10 −5 updated 05/30/16, 11:40

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • Michael Oehlhof +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 16

  1. Markus Klein uploaded patch set 1 05/17/16, 12:23

  2. Georg Ringer voted on patch set 1 CR +1 V +1 05/17/16, 18:48

  3. Wouter Wolters voted on patch set 1 CR +1 05/25/16, 21:04

  4. Andreas Kienast voted on patch set 1 CR +1 05/26/16, 09:21

  5. Frank Nägler commented on patch set 1 V -1 05/27/16, 08:18

    AbstractFile.php:193

    this a behavior change. if I have not made a mistake, this test shows the problem: https://3v4l.org/lUMAs
  6. Markus Klein commented on patch set 1 CR -2 05/27/16, 09:01

    On it
  7. Markus Klein voted on patch set 1 CR 0 05/27/16, 09:06

  8. Markus Klein uploaded patch set 2 05/27/16, 09:06

  9. Wouter Wolters voted on patch set 2 CR +1 05/27/16, 09:22

  10. Markus Klein uploaded patch set 3 05/27/16, 09:23

  11. Michael Oehlhof voted on patch set 3 CR +1 05/27/16, 14:41

  12. Wouter Wolters voted on patch set 3 CR +1 V +1 05/27/16, 15:55

  13. Frank Nägler voted on patch set 3 CR +1 V +1 05/30/16, 11:40

  14. Frank Nägler voted on patch set 3 CR +2 V +2 05/30/16, 11:40

  15. Gerrit merged patch set 3 05/30/16, 11:40

  16. Frank Nägler commented on patch set 4 05/30/16, 11:40

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 5f965d0354d4d8f2bd892af501da2f3d1db9e5b0