Review main Merged

48229[BUGFIX] Adjust signature of PageTreeView::wrapIcon

Elmar Hinz CR +2 V +2 Easy +1 −1 updated 07/11/16, 08:59

Commit message

Adjust the signature to match the parent class.

Review

  • Code review CR +2
    • Benni Mack +2
    • Claus Due +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Elmar Hinz uploaded patch set 1 05/20/16, 17:11

  2. Elmar Hinz commented on patch set 1 05/20/16, 17:13

    Question: Should both classes pass $row by reference or none of them. In which case is a deprecation file required.
  3. Elmar Hinz updated the commit message in patch set 2 05/22/16, 08:17

  4. Elmar Hinz commented on patch set 2 05/22/16, 08:26

    All other uses of wrapIcon don't use by-reference. PHP uses copy-on-write. There is no gain in using a reference here. http://php.net/manual/en/internals2.variables.intro.php
  5. Christian Kuhn updated the commit message in patch set 3 07/09/16, 13:09

  6. Christian Kuhn rebased onto patch set 4 07/09/16, 13:09

  7. Christian Kuhn commented on patch set 4 07/09/16, 13:10

    maybe 7.6, too?
  8. Christian Kuhn updated the commit message in patch set 5 07/09/16, 13:13

  9. Christian Kuhn voted on patch set 5 CR +1 V +1 07/09/16, 13:13

  10. TYPO3com voted on patch set 3 V +1 07/09/16, 13:16 Completed build in 07m 08s on Sat, 9 Jul, 03:16 PM Test Summary: 18410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-652

  11. TYPO3com voted on patch set 4 V +1 07/09/16, 13:18 Completed build in 09m 15s on Sat, 9 Jul, 03:18 PM Test Summary: 18410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-653

  12. TYPO3com voted on patch set 5 V +1 07/09/16, 13:20 Completed build in 07m 24s on Sat, 9 Jul, 03:20 PM Test Summary: 18410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-654

  13. Claus Due voted on patch set 5 CR +1 07/10/16, 10:26

  14. Benni Mack voted on patch set 5 CR +2 V +2 07/11/16, 08:58

  15. Gerrit merged patch set 5 07/11/16, 08:58

  16. Benni Mack commented on patch set 6 07/11/16, 08:59

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 7243ee677c2e3df28818faf659bec957cf10f49b