48265[BUGFIX] Allow non critical request arguments with @
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Stephan Großberndt +1
- Markus Klein +1
- Wouter Wolters +1
- Jan Helke +1
- Frank Nägler +1
- Christian Kuhn +1
- Tymoteusz Motylewski +1
- Frans Saris +1
- Andreas Kienast +1
- Jigal van Hemert +1
- Oliver Hader +1
-
Verified V +2
- Helmut Hummel +2
- Stephan Großberndt +1
- Wouter Wolters +1
- Frank Nägler +1
- Christian Kuhn +1
- Tymoteusz Motylewski +1
- Frans Saris +1
- Andreas Kienast +1
- Jigal van Hemert +1
Issues 1
Files 1
Review log 29
Show 4 earlier messages
-
Jigal van Hemert commented on patch set 2 CR +1 V +1 05/24/16, 09:12
Tested with BE paginate widget in EM -
Stephan Großberndt voted on patch set 2 V +1 05/24/16, 09:13
-
Stephan Großberndt voted on patch set 2 CR +1 05/24/16, 09:14
-
Markus Klein commented on patch set 2 CR -2 05/24/16, 09:14
Blocking patch due to some more discussion in sec-team -
Helmut Hummel uploaded patch set 3 05/24/16, 09:16
-
Andreas Kienast voted on patch set 3 CR +1 05/24/16, 09:16
-
Markus Klein voted on patch set 3 CR 0 05/24/16, 09:17
-
Helmut Hummel uploaded patch set 4 05/24/16, 09:19
-
Stephan Großberndt commented on patch set 3 05/24/16, 09:19
Request.php:393this creates a new array every time and thus makes performance worse. Why not explicitly compare? -
Christian Kuhn commented on patch set 4 05/24/16, 09:20
Stephan, performance is not an issue right now, this is called only once per request ... -
Christian Kuhn voted on patch set 4 CR +1 V +1 05/24/16, 09:21
-
Frans Saris voted on patch set 4 CR +1 V +1 05/24/16, 09:22
-
Stephan Großberndt voted on patch set 4 CR +1 V +1 05/24/16, 09:22
-
Tymoteusz Motylewski voted on patch set 4 CR +1 V +1 05/24/16, 09:22
-
Jigal van Hemert voted on patch set 4 CR +1 V +1 05/24/16, 09:22
-
Wouter Wolters voted on patch set 4 CR +1 V +1 05/24/16, 09:23
-
Andreas Kienast voted on patch set 4 CR +1 V +1 05/24/16, 09:24
-
Jan Helke voted on patch set 4 CR +1 05/24/16, 09:24
-
Frank Nägler voted on patch set 4 CR +1 V +1 05/24/16, 09:25
-
Helmut Hummel commented on patch set 4 05/24/16, 09:30
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 61483ad8ca9c0d42d72fe3a5766fa04f97fd1574 -
Markus Klein voted on patch set 4 CR +1 05/24/16, 09:33
-
Markus Klein commented on patch set 4 05/24/16, 09:34
Cherry Picked This patchset was cherry picked to branch TYPO3_8-1 as commit 2f001c8acf733d536136ef26d2f3e186fe5a4c25 -
Oliver Hader voted on patch set 4 CR +1 05/24/16, 09:39
-
Helmut Hummel voted on patch set 4 CR +2 V +2 05/24/16, 09:42
-
Gerrit merged patch set 4 05/24/16, 09:42