Review main Merged

48265[BUGFIX] Allow non critical request arguments with @

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 05/24/16, 09:42

Commit message

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Stephan Großberndt +1
    • Markus Klein +1
    • Wouter Wolters +1
    • Jan Helke +1
    • Frank Nägler +1
    • Christian Kuhn +1
    • Tymoteusz Motylewski +1
    • Frans Saris +1
    • Andreas Kienast +1
    • Jigal van Hemert +1
    • Oliver Hader +1
  • Verified V +2
    • Helmut Hummel +2
    • Stephan Großberndt +1
    • Wouter Wolters +1
    • Frank Nägler +1
    • Christian Kuhn +1
    • Tymoteusz Motylewski +1
    • Frans Saris +1
    • Andreas Kienast +1
    • Jigal van Hemert +1

Issues 1

Files 1

Review log 29

Show 4 earlier messages
  1. Helmut Hummel uploaded patch set 1 05/24/16, 09:08

  2. Helmut Hummel updated the commit message in patch set 2 05/24/16, 09:10

  3. Andreas Kienast voted on patch set 2 CR +1 05/24/16, 09:10

  4. Frans Saris voted on patch set 2 CR +1 V +1 05/24/16, 09:10

  1. Jigal van Hemert commented on patch set 2 CR +1 V +1 05/24/16, 09:12

    Tested with BE paginate widget in EM
  2. Stephan Großberndt voted on patch set 2 V +1 05/24/16, 09:13

  3. Stephan Großberndt voted on patch set 2 CR +1 05/24/16, 09:14

  4. Markus Klein commented on patch set 2 CR -2 05/24/16, 09:14

    Blocking patch due to some more discussion in sec-team
  5. Helmut Hummel uploaded patch set 3 05/24/16, 09:16

  6. Andreas Kienast voted on patch set 3 CR +1 05/24/16, 09:16

  7. Markus Klein voted on patch set 3 CR 0 05/24/16, 09:17

  8. Helmut Hummel uploaded patch set 4 05/24/16, 09:19

  9. Stephan Großberndt commented on patch set 3 05/24/16, 09:19

    Request.php:393

    this creates a new array every time and thus makes performance worse. Why not explicitly compare?
  10. Christian Kuhn commented on patch set 4 05/24/16, 09:20

    Stephan, performance is not an issue right now, this is called only once per request ...
  11. Christian Kuhn voted on patch set 4 CR +1 V +1 05/24/16, 09:21

  12. Frans Saris voted on patch set 4 CR +1 V +1 05/24/16, 09:22

  13. Stephan Großberndt voted on patch set 4 CR +1 V +1 05/24/16, 09:22

  14. Tymoteusz Motylewski voted on patch set 4 CR +1 V +1 05/24/16, 09:22

  15. Jigal van Hemert voted on patch set 4 CR +1 V +1 05/24/16, 09:22

  16. Wouter Wolters voted on patch set 4 CR +1 V +1 05/24/16, 09:23

  17. Andreas Kienast voted on patch set 4 CR +1 V +1 05/24/16, 09:24

  18. Jan Helke voted on patch set 4 CR +1 05/24/16, 09:24

  19. Frank Nägler voted on patch set 4 CR +1 V +1 05/24/16, 09:25

  20. Helmut Hummel commented on patch set 4 05/24/16, 09:30

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 61483ad8ca9c0d42d72fe3a5766fa04f97fd1574
  21. Markus Klein voted on patch set 4 CR +1 05/24/16, 09:33

  22. Markus Klein commented on patch set 4 05/24/16, 09:34

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-1 as commit 2f001c8acf733d536136ef26d2f3e186fe5a4c25
  23. Oliver Hader voted on patch set 4 CR +1 05/24/16, 09:39

  24. Helmut Hummel voted on patch set 4 CR +2 V +2 05/24/16, 09:42

  25. Gerrit merged patch set 4 05/24/16, 09:42