Review main Merged Breaking

48276[!!!][BUGFIX] Load popup configuration in case backend submodules are opened in a new tab

Andreas Kienast CR +2 V +2 Normal +79 −56 updated 05/27/16, 09:17

Commit message

It's possible to open some backend modules (e.g. RTE or
EditDocumentController) in a new tab. However, the configuration for
popups is missing in such case, causing e.g. opening the "Insert image"
wizard of RTE is not possible anymore.

Place configuration inline in TYPO3.settings to not have this problem of
missing configuration.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Andreas Kienast +1

Issues 1

Files 8

Review log 22

  1. Andreas Kienast uploaded patch set 1 05/24/16, 13:12

  2. Markus Klein commented on patch set 1 05/24/16, 13:52

    BackendUtility.php:4295

    Really? Yet another new method in this class?
  3. Andreas Kienast commented on patch set 1 05/24/16, 14:05

    BackendUtility.php:4295 Reply

    Either that or maintaining the same code in three different classes.
  4. Helmut Hummel commented on patch set 1 05/24/16, 18:08

    -2 on introducing a new static method into BackendUtility

    BackendUtility.php:4295 Reply

    I bet there is another alternative…
  5. Andreas Kienast commented on patch set 1 05/24/16, 18:19

    BackendUtility.php:4295 Reply

    As this method already calls stuff from BE_USER, do you agree to put it in BackendUserAuthentication instead?
  6. Christian Kuhn commented on patch set 1 05/26/16, 12:23

    drop one usage: sysext/backend/Resources/Public/JavaScript/ContextHelp.js 109:var configuration = top.TYPO3.configuration.ContextHelpWindows || top.TYPO3.configuration.PopupWindow; the part behind || can be removed, first is always set in BackendController.
  7. Wouter Wolters uploaded patch set 2 05/26/16, 13:16

  8. Wouter Wolters updated the commit message in patch set 3 05/26/16, 13:22

  9. Andreas Kienast voted on patch set 3 CR +1 V +1 05/27/16, 06:55

  10. Frank Nägler commented on patch set 3 CR -1 05/27/16, 07:47

    this is a breaking change, and should be marked as breaking + rst file. The settings: top.TYPO3.configuration.RTEPopupWindow and top.TYPO3.configuration.PopupWindow are both public and could be used by extensions. At least gridelements use the PopupWindow settings.
  11. Wouter Wolters uploaded patch set 4 05/27/16, 08:29

  12. Andreas Kienast commented on patch set 5 05/27/16, 08:30

    Published edit on patch set 4.
  13. Andreas Kienast voted on patch set 5 CR +1 V +1 05/27/16, 08:30

  14. Andreas Kienast voted on patch set 5 CR 0 05/27/16, 08:33

  15. Wouter Wolters commented on patch set 6 05/27/16, 08:36

    Published edit on patch set 5.
  16. Andreas Kienast voted on patch set 6 CR +1 V +1 05/27/16, 08:36

  17. Frank Nägler voted on patch set 6 CR +1 05/27/16, 08:39

  18. Frank Nägler commented on patch set 6 V -1 05/27/16, 08:48

    there are a lot of thinks broken with this patch. Some examples: 1) Open EditDocumentController in Popup > Help Icon > Click "more" icon == broken 2) Open EditDocumentController in Popup > Tab Resources > Add FAL relation == broken
  19. Frank Nägler commented on patch set 6 05/27/16, 08:51

    hint: the behavior is different for editing a page and a content element in the popup. very strange the popup thing
  20. Frank Nägler commented on patch set 6 V +1 05/27/16, 09:14

    looks like cache issue, works now for me
  21. Frank Nägler voted on patch set 6 CR +2 V +2 05/27/16, 09:16

  22. Gerrit merged patch set 6 05/27/16, 09:17