48276[!!!][BUGFIX] Load popup configuration in case backend submodules are opened in a new tab
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Andreas Kienast +1
-
Verified V +2
- Frank Nägler +2
- Andreas Kienast +1
Issues 1
Files 8
- typo3/sysext/backend/Classes/Controller/BackendController.php+0 −23
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −25
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+30 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextHelp.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-76285-PopupConfigurationIsMovedToTYPO3settings.rstnew+41 −0
- typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Plugins/TYPO3Image.js+2 −2
- typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Plugins/TYPO3Link.js+2 −2
Review log 22
-
Andreas Kienast uploaded patch set 1 05/24/16, 13:12
-
Markus Klein commented on patch set 1 05/24/16, 13:52
-
Andreas Kienast commented on patch set 1 05/24/16, 14:05
BackendUtility.php:4295ReplyEither that or maintaining the same code in three different classes. -
Helmut Hummel commented on patch set 1 05/24/16, 18:08
-2 on introducing a new static method into BackendUtilityBackendUtility.php:4295ReplyI bet there is another alternative… -
Andreas Kienast commented on patch set 1 05/24/16, 18:19
BackendUtility.php:4295ReplyAs this method already calls stuff from BE_USER, do you agree to put it in BackendUserAuthentication instead? -
Christian Kuhn commented on patch set 1 05/26/16, 12:23
drop one usage: sysext/backend/Resources/Public/JavaScript/ContextHelp.js 109:var configuration = top.TYPO3.configuration.ContextHelpWindows || top.TYPO3.configuration.PopupWindow; the part behind || can be removed, first is always set in BackendController. -
Wouter Wolters uploaded patch set 2 05/26/16, 13:16
-
Wouter Wolters updated the commit message in patch set 3 05/26/16, 13:22
-
Andreas Kienast voted on patch set 3 CR +1 V +1 05/27/16, 06:55
-
Frank Nägler commented on patch set 3 CR -1 05/27/16, 07:47
this is a breaking change, and should be marked as breaking + rst file. The settings: top.TYPO3.configuration.RTEPopupWindow and top.TYPO3.configuration.PopupWindow are both public and could be used by extensions. At least gridelements use the PopupWindow settings. -
Wouter Wolters uploaded patch set 4 05/27/16, 08:29
-
Andreas Kienast commented on patch set 5 05/27/16, 08:30
Published edit on patch set 4. -
Andreas Kienast voted on patch set 5 CR +1 V +1 05/27/16, 08:30
-
Andreas Kienast voted on patch set 5 CR 0 05/27/16, 08:33
-
Wouter Wolters commented on patch set 6 05/27/16, 08:36
Published edit on patch set 5. -
Andreas Kienast voted on patch set 6 CR +1 V +1 05/27/16, 08:36
-
Frank Nägler voted on patch set 6 CR +1 05/27/16, 08:39
-
Frank Nägler commented on patch set 6 V -1 05/27/16, 08:48
there are a lot of thinks broken with this patch. Some examples: 1) Open EditDocumentController in Popup > Help Icon > Click "more" icon == broken 2) Open EditDocumentController in Popup > Tab Resources > Add FAL relation == broken -
Frank Nägler commented on patch set 6 05/27/16, 08:51
hint: the behavior is different for editing a page and a content element in the popup. very strange the popup thing -
Frank Nägler commented on patch set 6 V +1 05/27/16, 09:14
looks like cache issue, works now for me -
Frank Nägler voted on patch set 6 CR +2 V +2 05/27/16, 09:16
-
Gerrit merged patch set 6 05/27/16, 09:17
BackendUtility.php:4295