48281[FEATURE] ViewHelpers f:form.select.option and f:form.select.optgroup
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Jan Helke +1
-
Verified V +2
- Susi Moog +2
- Jan Helke +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Feature-29399-OptionViewHelperAndOptgroupViewHelperForUseWithSelectViewHelper.rst1new+41 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptgroupViewHelper.phpnew+56 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptionViewHelper.phpnew+88 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+39 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.php+1 −1
Review log 2228
Show 3 earlier messages
-
Anja Leichsenring commented on patch set 3 10/27/16, 09:00
would you provide a code example in the rst and / or in the class description, please? Makes it easier to test and update documentation. Thanks. -
Anja Leichsenring rebased onto patch set 4 10/27/16, 12:52
-
TYPO3com voted on patch set 4 V -1 10/27/16, 12:56 Completed build in 04m 02s on Thu, 27 Oct, 02:56 PM Test Summary: 40 of 19569 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4328
-
Claus Due uploaded patch set 5 10/30/16, 21:17
-
Claus Due commented on patch set 5 10/30/16, 21:19
VH class docs added (for f:form.select, the others simply refer to f:form.select and don't really require any special examples - arguments have docs). -
TYPO3com voted on patch set 5 V -1 10/30/16, 21:21 Completed build in 04m 02s on Sun, 30 Oct, 10:21 PM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4451
-
Claus Due uploaded patch set 6 10/30/16, 21:25
-
TYPO3com voted on patch set 6 V -1 10/30/16, 21:30 Completed build in 04m 48s on Sun, 30 Oct, 10:30 PM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4452
-
Claus Due uploaded patch set 7 10/30/16, 21:33
-
TYPO3com voted on patch set 7 V +1 10/30/16, 21:38 Completed build in 04m 28s on Sun, 30 Oct, 10:38 PM Test Summary: 19587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4453
-
Jörg Bösche commented on patch set 7 CR -1 11/01/16, 06:37
I miss a parent::initializeArguments(); call in the new view helpers. Just as we did in other fluid view helpers. See here: https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php#L91 -
Claus Due uploaded patch set 8 11/20/16, 21:36
-
Claus Due commented on patch set 8 11/20/16, 21:38
> I miss a parent::initializeArguments(); call in the new view helpers. Just as we did in other fluid view helpers. Technically speaking, the two new ViewHelpers are *not* Form field ViewHelpers and doing parent::initializeArguments() would among other things give each one a "name" and "property" argument which would not do anything. So rather than do that, but respecting the fact that these are tag based ViewHelpers, I updated the patch and added the "data" and "additionalAttributes" arguments to allow further manipulation of the tag. In other words, not calling parent::initializeArguments is quite intentional :) -
TYPO3com voted on patch set 8 V +1 11/20/16, 21:40 Completed build in 04m 23s on Sun, 20 Nov, 10:40 PM Test Summary: 55331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5067
-
Georg Ringer commented on patch set 8 CR +1 V +1 11/21/16, 12:23
Feature-29399-OptionViewHelperAndOptgroupViewHelperForUseWithSelectViewHelper.rst:26please add at least one example for each new ViewHelper, thx -
Claus Due commented on patch set 8 11/21/16, 14:32
Documentation is embedded in VH f:form.select - would it be enough to copy this new example to the RST? https://review.typo3.org/#/c/48281/8/typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php -
Jan Helke commented on patch set 8 CR +1 V +1 12/02/16, 11:49
I would say, that would be enough but very helpful. -
Jörg Bösche voted on patch set 8 CR +1 12/02/16, 12:30
-
Susi Moog commented on patch set 8 CR -1 12/02/16, 13:38
will update the rst -
Susi Moog uploaded patch set 9 12/02/16, 13:43
-
Susi Moog voted on patch set 9 CR +1 V +1 12/02/16, 13:44
-
Jan Helke voted on patch set 9 CR +1 V +1 12/02/16, 13:45
-
TYPO3com voted on patch set 9 V +1 12/02/16, 13:49 Completed build in 05m 06s on Fri, 2 Dec, 02:49 PM Test Summary: 54119 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5331
-
Susi Moog voted on patch set 9 CR +2 V +2 12/02/16, 13:49
-
Gerrit merged patch set 9 12/02/16, 13:49