48288[BUGFIX] Fix output of DebugUtility
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Markus Klein +1
- Nicole Hummel +1
-
Verified V +2
- Helmut Hummel +2
- Markus Klein +1
- Nicole Hummel +1
Issues 1
Files 4
Review log 41
Show 16 earlier messages
-
Helmut Hummel uploaded patch set 1 05/25/16, 17:36
-
Markus Klein commented on patch set 1 05/25/16, 18:20
-
Elmar Hinz commented on patch set 1 05/25/16, 18:48
DebugUtility.php:40$debug doesn't seem to be used. -
Elmar Hinz commented on patch set 1 05/25/16, 18:55
DebugUtility.php:40ReplyFound the usage. However it is rendered twice, what feels a little strange. Sure it is not critical for this. -
Wouter Wolters commented on patch set 1 CR -1 05/25/16, 20:50
5 failing test here -
Helmut Hummel commented on patch set 1 05/25/16, 21:14
DebugUtility.php:40ReplyWhat di you mean with twice? It is used HTML encoded once and not HTML encoded a second time -
Helmut Hummel uploaded patch set 2 05/25/16, 21:39
-
Elmar Hinz commented on patch set 2 V -1 05/26/16, 06:48
ContentObjectRendererTest.php is O.K. DebugUtility gives me mixed output in the context of a simple unit test. ``` stdClass prototype object b => stdClass prototype object c => stdClass prototype object<span class="extbase-debug-visibility">public</span><span class="extbase-debug-visibility">public</span> ```DebugUtility.php:40ReplyThat's fine. No need to consider performance in this place. -
Helmut Hummel commented on patch set 1 05/26/16, 07:13
@elmar: You are affected by a bug which is fixed here: https://review.typo3.org/#/c/48287 -
Elmar Hinz commented on patch set 2 V 0 05/26/16, 07:19
Yes, if I cherrypick both it doesn't happen. -
Elmar Hinz uploaded patch set 3 05/26/16, 08:36
-
Elmar Hinz commented on patch set 3 V -1 05/26/16, 08:41
I added some tests. They will only work if the patch for this Bug is applied: https://review.typo3.org/#/c/48287 Attention to the test debugInPopUpWindow(). This needs improvement. I think it currently indicates that there are command line shell escapes in the JavaScript message. For this reason -1 for verified. -
Elmar Hinz commented on patch set 3 05/26/16, 08:50
For the test there is the issue, that the DebugUtilityl is context dependent especially dependent on constants. I guess setting constants requires to run phpunit with processIsolation="true". \TYPO3\CMS\Core\Tests\UnitTestCase is run with processIsolation="false". It may be better to make this a functional test for this reason. -
Elmar Hinz commented on patch set 3 05/26/16, 08:59
The other tests don't return the "Header (Group)" of the debugInPopUpWindow(). -
Nicole Hummel uploaded patch set 4 05/26/16, 10:49
-
Nicole Hummel voted on patch set 4 CR +1 V +1 05/26/16, 10:49
-
Wouter Wolters commented on patch set 4 05/26/16, 11:04
DebugUtility.php:208renderDump directly -
Nicole Hummel uploaded patch set 5 05/26/16, 11:17
-
Nicole Hummel voted on patch set 5 CR +1 V +1 05/26/16, 11:17
-
Nicole Hummel commented on patch set 4 05/26/16, 11:17
DebugUtility.php:208ReplyDone -
Elmar Hinz commented on patch set 5 05/26/16, 13:01
DebugUtility.php:69Is it by intention that the header is not applied here? In case of multiple calls within cli one or two line breaks would be useful.DebugUtility.php:208Linebreak? -
Nicole Hummel commented on patch set 5 05/26/16, 13:06
DebugUtility.php:69ReplyI guess the header isn't shown for a security reason in frontend. A debugging tool is not responsible to add any line breaks.DebugUtility.php:208ReplyA debugging tool is not responsible to add any line breaks. -
Elmar Hinz commented on patch set 5 05/26/16, 13:23
DebugUtility.php:69ReplyIsn't it for CLI usage as well? "Directly echos out debug information as HTML (or plain in CLI context)" Isn't the responsibility of a debugging tool is to pretty print the variable contents? Doesn't that include the support of multiple calls? In the HTML output it does at least. :) Possibly it should already be handled by the Extbase DebuggerUtility. -
Elmar Hinz commented on patch set 5 V -1 05/26/16, 14:02
CLI Test # Given ``` DebugUtility::debug([1, 2], 'Integers'); DebugUtility::debug(['one', 'two'], 'Strings'); ``` # Expected output: ``` Integers: 0 => 1 (integer) 1 => 2 (integer)array(2 items) Strings: 0 => "one" (3 chars) 1 => "two" (3 chars) ``` # Actual output: ``` 0 => 1 (integer) 1 => 2 (integer)array(2 items) 0 => "one" (3 chars) 1 => "two" (3 chars) ``` -
Elmar Hinz commented on patch set 5 05/26/16, 14:05
CLI Test (UPDATE) # Given ``` DebugUtility::debug([1, 2], 'Integers'); DebugUtility::debug(['one', 'two'], 'Strings'); ``` # Expected output: ``` Integers: array(2 items) 0 => 1 (integer) 1 => 2 (integer) Strings: array(2 items) 0 => "one" (3 chars) 1 => "two" (3 chars) ``` # Actual output: ``` array(2 items) 0 => 1 (integer) 1 => 2 (integer)array(2 items) 0 => "one" (3 chars) 1 => "two" (3 chars) ``` -
Elmar Hinz commented on patch set 5 CR -1 05/26/16, 14:48
DebugUtility.php:234Guess this bitwise & is a typo. -
Markus Klein commented on patch set 5 05/26/16, 22:58
DebugUtility.php:234ReplyNo, definitely not. Please see how TYPO3_REQUESTTYPE is defined. -
Elmar Hinz voted on patch set 5 CR +1 05/27/16, 04:26
-
Helmut Hummel rebased onto patch set 6 05/28/16, 16:25
-
Helmut Hummel uploaded patch set 7 05/28/16, 16:56
-
Markus Klein voted on patch set 7 CR +1 05/28/16, 17:54
-
Helmut Hummel uploaded patch set 8 05/28/16, 19:31
-
Helmut Hummel uploaded patch set 9 05/28/16, 19:59
-
Markus Klein voted on patch set 9 CR +1 05/28/16, 20:45
-
Helmut Hummel uploaded patch set 10 05/28/16, 23:15
-
Nicole Hummel voted on patch set 10 CR +1 V +1 05/29/16, 07:50
-
Markus Klein uploaded patch set 11 05/29/16, 09:15
-
Markus Klein voted on patch set 11 CR +1 V +1 05/29/16, 09:16
-
Nicole Hummel commented on patch set 11 CR +1 V +1 05/29/16, 10:17
Tested with FF, Chrome and IE11 on Windows 7 -
Helmut Hummel voted on patch set 11 CR +2 V +2 05/29/16, 10:29
-
Gerrit merged patch set 11 05/29/16, 10:29
DebugUtility.php:199