Review main Abandoned

48300[WIP][TASK] Use PHP7 unserialize no objects

Christian Kuhn CR 0 V 0 Normal +113 −107 updated 10/19/16, 09:37

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 64

Show 44 more files

Review log 12

  1. Christian Kuhn uploaded patch set 1 05/26/16, 17:17

  2. Christian Kuhn commented on patch set 1 05/26/16, 19:20

    ColorpickerController.php:160

    typo ,,
  3. Christian Kuhn commented on patch set 1 CR -1 05/26/16, 19:21

    this patch should be split into multiple patches ...
  4. Oliver Hader commented on patch set 1 V -1 05/26/16, 19:32

    Abstract classes and interfaces are not considered concerning resolving the inheritance chain. Thus, it has be to checked for the specific implementation - using the abstract class is not sufficient
  5. Oliver Hader commented on patch set 1 05/26/16, 20:15

    On the inheritance thingy... https://gist.github.com/ohader/72f437972eed4d69280693b82ed1b82c Might become expensive and thus should/could be used only where it makes sense - otherwise direct unserialize with strict class names
  6. Christian Kuhn uploaded patch set 2 05/27/16, 12:40

  7. Christian Kuhn voted on patch set 2 CR -2 05/27/16, 12:41

  8. Andreas Allacher commented on patch set 1 05/27/16, 14:13

    @Oliver Hader: Maybe is_subclass_of instead of is_a would be better as is_a would also be true for the object itself. On the other hand if it is the object istelf unserialize should not have resulted into __PHP_Incomplete_Class Not sure if is_a or if is_subclass_of is faster?
  9. Christian Kuhn uploaded patch set 3 05/28/16, 14:55

  10. Christian Kuhn commented on patch set 3 05/28/16, 14:56

    andreas, we will try to further reduce the big load of usages first and then we'll see what is left and if we need to finish the PoC by Olly.
  11. Christian Kuhn uploaded patch set 4 05/28/16, 15:02

  12. Christian Kuhn abandoned the change 10/19/16, 09:37

    abandoned for now - this patch is more a reference than an target to be merged.