48300[WIP][TASK] Use PHP7 unserialize no objects
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 64
- typo3/sysext/backend/Classes/Controller/Wizard/ColorpickerController.php1+1 −1
- typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php+1 −1
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseLanguageRows.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineExpandCollapseState.php+2 −2
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −1
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizard.php+1 −1
- typo3/sysext/backend/Classes/History/RecordHistory.php+3 −3
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+1 −1
- typo3/sysext/backend/Classes/Tree/View/FolderTreeView.php+1 −1
- typo3/sysext/backend/Classes/Tree/TreeNode.php+1 −1
- typo3/sysext/backend/Classes/Tree/TreeNodeCollection.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/belog/Classes/Controller/AbstractController.php+12 −11
- typo3/sysext/belog/Classes/Controller/SystemInformationController.php+2 −2
- typo3/sysext/belog/Classes/Domain/Model/LogEntry.php+1 −1
- typo3/sysext/beuser/Classes/Service/ModuleDataStorageService.php+7 −5
- typo3/sysext/compatibility7/Classes/Controller/SearchFormController.php+2 −2
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+3 −3
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+2 −2
Show 44 more files
- typo3/sysext/core/Classes/Cache/Backend/FileBackend.php+1 −1
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+5 −5
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php+1 −1
- typo3/sysext/core/Classes/Compatibility/LoadedExtensionArrayElement.php+1 −1
- typo3/sysext/core/Classes/Compatibility/LoadedExtensionsArray.php+2 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+2 −2
- typo3/sysext/core/Classes/Database/QueryGenerator.php+1 −1
- typo3/sysext/core/Classes/Database/QueryView.php+3 −3
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −2
- typo3/sysext/core/Classes/Package/PackageManager.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+1 −1
- typo3/sysext/core/Classes/Registry.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+1 −1
- typo3/sysext/dbal/Classes/Controller/ModuleController.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/MvcPropertyMappingConfigurationService.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Web/Request.php+2 −2
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ConfigurationItemRepository.php+2 −1
- typo3/sysext/extensionmanager/Classes/Utility/Connection/TerUtility.php+2 −2
- typo3/sysext/extensionmanager/Classes/Utility/Parser/AbstractExtensionXmlParser.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/ExtensionModelUtility.php+1 −1
- typo3/sysext/fluid/Classes/Core/Widget/AjaxWidgetContextHolder.php+2 −2
- typo3/sysext/fluid_styled_content/Configuration/TCA/Overrides/pages.php+1 −1
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+2 −2
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+1 −1
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+1 −1
- typo3/sysext/install/Classes/Updates/BackendUserStartModuleUpdate.php+1 −1
- typo3/sysext/install/Classes/Updates/BackendUserStartModuleUpdateAboutModule.php+1 −1
- typo3/sysext/install/Classes/Updates/FileListIsStartModuleUpdate.php+1 −1
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −1
- typo3/sysext/lowlevel/Classes/SyslogCommand.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+4 −4
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+2 −2
- typo3/sysext/scheduler/Classes/Scheduler.php+5 −4
- typo3/sysext/sys_action/Classes/ActionTask.php+1 −1
- typo3/sysext/taskcenter/Classes/Controller/TaskModuleController.php+1 −1
- typo3/sysext/version/Classes/Hook/DataHandlerHook.php+1 −1
- typo3/sysext/version/Classes/Hook/PreviewHook.php+1 −1
- typo3/sysext/workspaces/Classes/ExtDirect/ActionHandler.php+2 −2
- typo3/sysext/workspaces/Classes/ExtDirect/ExtDirectServer.php+1 −1
Review log 12
-
Christian Kuhn uploaded patch set 1 05/26/16, 17:17
-
Christian Kuhn commented on patch set 1 05/26/16, 19:20
-
Christian Kuhn commented on patch set 1 CR -1 05/26/16, 19:21
this patch should be split into multiple patches ... -
Oliver Hader commented on patch set 1 V -1 05/26/16, 19:32
Abstract classes and interfaces are not considered concerning resolving the inheritance chain. Thus, it has be to checked for the specific implementation - using the abstract class is not sufficient -
Oliver Hader commented on patch set 1 05/26/16, 20:15
On the inheritance thingy... https://gist.github.com/ohader/72f437972eed4d69280693b82ed1b82c Might become expensive and thus should/could be used only where it makes sense - otherwise direct unserialize with strict class names -
Christian Kuhn uploaded patch set 2 05/27/16, 12:40
-
Christian Kuhn voted on patch set 2 CR -2 05/27/16, 12:41
-
Andreas Allacher commented on patch set 1 05/27/16, 14:13
@Oliver Hader: Maybe is_subclass_of instead of is_a would be better as is_a would also be true for the object itself. On the other hand if it is the object istelf unserialize should not have resulted into __PHP_Incomplete_Class Not sure if is_a or if is_subclass_of is faster? -
Christian Kuhn uploaded patch set 3 05/28/16, 14:55
-
Christian Kuhn commented on patch set 3 05/28/16, 14:56
andreas, we will try to further reduce the big load of usages first and then we'll see what is left and if we need to finish the PoC by Olly. -
Christian Kuhn uploaded patch set 4 05/28/16, 15:02
-
Christian Kuhn abandoned the change 10/19/16, 09:37
abandoned for now - this patch is more a reference than an target to be merged.
ColorpickerController.php:160