Review main Abandoned

48302[BUGFIX] Re-enables fileDenyPattern check for admin users

Torben Hansen CR 0 V 0 Normal +53 −5 updated 05/26/16, 19:33

Commit message

When an admin user tries to upload a file which has a fileextension
that is included in the fileDenyPattern, the upload is denied.

With the security fix in #51326 admin users are now able to change
the extension of a file to any value, since the fileDenyPattern is
not checked for admin users. This leads to the situation, that admin
users can create/rename files in the filelist with a fileextension
of their choice.

To keep the behavior consistent, this patch re-enables the check
of the fileDenyPattern for admin users in the filelist.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 2

  1. Torben Hansen uploaded patch set 1 05/26/16, 19:24

  2. Torben Hansen abandoned the change 05/26/16, 19:33

    Will reference commit to Change-Id: I3b819e70cf2218a4580203ac7b7a6b0c3c5087ab