Review main Merged

48320[TASK] Remove second parameter of getLL part 1/3

Wouter Wolters CR +2 V +2 Normal +94 −94 updated 05/27/16, 11:26

Commit message

Remove the second parameter of getLL and replace it
with htmlspecialchars directly in the code.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Markus Klein +1
  • Verified V +2
    • Morton Jonuschat +2
    • Markus Klein +1

Issues 2

Files 16

Review log 12

  1. Wouter Wolters uploaded patch set 1 05/27/16, 11:05

  2. Wouter Wolters commented on patch set 1 05/27/16, 11:06

    Warning: Some second parameters are not replaced with htmlspecialchars because they are not needed in a FlashMessage.
  3. Morton Jonuschat commented on patch set 1 05/27/16, 11:10

    FileListController.php:232

    Can't this be removed as well (see line 212)
  4. Wouter Wolters uploaded patch set 2 05/27/16, 11:12

  5. Morton Jonuschat voted on patch set 2 CR +1 05/27/16, 11:13

  6. Markus Klein commented on patch set 1 05/27/16, 11:15

    ImportExportController.php:852

    this is assigned to a view, IMO the view is responsible for the correct escaping depending on the format

    ImportExportController.php:854

    same here

    ImportExport.php:916

    missing )
  7. Markus Klein commented on patch set 2 CR -1 05/27/16, 11:15

    see my comments set 1
  8. Morton Jonuschat uploaded patch set 3 05/27/16, 11:17

  9. Wouter Wolters uploaded patch set 4 05/27/16, 11:18

  10. Markus Klein voted on patch set 4 CR +1 V +1 05/27/16, 11:20

  11. Morton Jonuschat voted on patch set 4 CR +2 V +2 05/27/16, 11:26

  12. Gerrit merged patch set 4 05/27/16, 11:26