48320[TASK] Remove second parameter of getLL part 1/3
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Markus Klein +1
-
Verified V +2
- Morton Jonuschat +2
- Markus Klein +1
Issues 2
Files 16
- typo3/sysext/core/Classes/Database/QueryView.php+2 −2
- typo3/sysext/filelist/Classes/Controller/FileListController.php1+10 −10
- typo3/sysext/filelist/Classes/FileFacade.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php+15 −15
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php2+2 −2
- typo3/sysext/impexp/Classes/ImportExport.php1+6 −6
- typo3/sysext/lowlevel/Classes/View/DatabaseIntegrityView.php+12 −12
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+4 −4
- typo3/sysext/rtehtmlarea/Classes/Controller/BrowseLinksController.php+8 −8
- typo3/sysext/rtehtmlarea/Classes/Controller/UserElementsController.php+5 −5
- typo3/sysext/rtehtmlarea/Classes/ImageHandler/AddImageHandler.php+6 −6
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+11 −11
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+3 −3
- typo3/sysext/taskcenter/Classes/Controller/TaskModuleController.php+3 −3
- typo3/sysext/wizard_sortpages/Classes/View/SortPagesWizardModuleFunction.php+3 −3
- typo3/sysext/workspaces/Classes/Backend/ToolbarItems/WorkspaceSelectorToolbarItem.php+3 −3
Review log 12
-
Wouter Wolters uploaded patch set 1 05/27/16, 11:05
-
Wouter Wolters commented on patch set 1 05/27/16, 11:06
Warning: Some second parameters are not replaced with htmlspecialchars because they are not needed in a FlashMessage. -
Morton Jonuschat commented on patch set 1 05/27/16, 11:10
FileListController.php:232Can't this be removed as well (see line 212) -
Wouter Wolters uploaded patch set 2 05/27/16, 11:12
-
Morton Jonuschat voted on patch set 2 CR +1 05/27/16, 11:13
-
Markus Klein commented on patch set 1 05/27/16, 11:15
ImportExportController.php:852this is assigned to a view, IMO the view is responsible for the correct escaping depending on the formatImportExportController.php:854same hereImportExport.php:916missing ) -
Markus Klein commented on patch set 2 CR -1 05/27/16, 11:15
see my comments set 1 -
Morton Jonuschat uploaded patch set 3 05/27/16, 11:17
-
Wouter Wolters uploaded patch set 4 05/27/16, 11:18
-
Markus Klein voted on patch set 4 CR +1 V +1 05/27/16, 11:20
-
Morton Jonuschat voted on patch set 4 CR +2 V +2 05/27/16, 11:26
-
Gerrit merged patch set 4 05/27/16, 11:26