Review main Merged

48321[TASK] IconViewHelper should generate absolute URLs

Benni Mack CR +2 V +2 Easy +3 −10 updated 05/27/16, 12:32

Commit message

This change allows the IconViewHelper in the reports module
to be used not just from typo3/ (e.g. if a person puts typo3/index.php
to a different place or wants to show the reports in the install tool).

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Frank Nägler +1
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Frank Nägler +1
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 8

  1. Benni Mack uploaded patch set 1 05/27/16, 11:16

  2. Benni Mack uploaded patch set 2 05/27/16, 11:28

  3. Morton Jonuschat uploaded patch set 3 05/27/16, 12:16

  4. Morton Jonuschat voted on patch set 3 CR +1 V +1 05/27/16, 12:16

  5. Frank Nägler commented on patch set 3 CR -1 05/27/16, 12:23

    temporary -1, will check it within the next hour
  6. Wouter Wolters voted on patch set 3 CR +2 V +2 05/27/16, 12:31

  7. Frank Nägler voted on patch set 3 CR +1 V +1 05/27/16, 12:32

  8. Gerrit merged patch set 3 05/27/16, 12:32