48324[WIP][TASK] Remove usages of TYPO3_LOADED_EXT
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 18
- typo3/sysext/about/Classes/Domain/Repository/ExtensionRepository.php+12 −13
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+7 −6
- typo3/sysext/core/Classes/Compatibility/LoadedExtensionArrayElement.php+5 −5
- typo3/sysext/core/Classes/Package/Package.php+88 −1
- typo3/sysext/core/Classes/Package/PackageManager.php+2 −2
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+12 −10
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+28 −22
- typo3/sysext/dbal/Classes/Database/DatabaseConnection.php+5 −7
- typo3/sysext/documentation/Classes/Domain/Repository/DocumentRepository.php+9 −6
- typo3/sysext/documentation/Classes/Service/DocumentationService.php+9 −7
- typo3/sysext/documentation/Classes/Utility/MiscUtility.php+6 −3
- typo3/sysext/extensionmanager/Classes/Utility/ConfigurationUtility.php+9 −5
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+2 −1
- typo3/sysext/install/Classes/Controller/Action/Ajax/ExtensionCompatibilityTester.php+14 −12
- typo3/sysext/install/Classes/Service/SqlExpectedSchemaService.php+11 −9
- typo3/sysext/lang/Classes/Domain/Repository/ExtensionRepository.php+8 −8
- typo3/sysext/lowlevel/Classes/View/ConfigurationView.php+13 −19
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf+0 −3
Review log 5
-
Benni Mack uploaded patch set 1 05/27/16, 11:21
-
Helmut Hummel commented on patch set 1 05/29/16, 15:43
I wouldn't do it like that. What we need from the TYPO3_LOADED_EXT are paths. Replacing the usages of this array with the package manager is a wrong approach. Instead we should introduce a resource resolver that handles paths to resources and replace the TYPO3_LOADED_EXT with that. -
Christian Kuhn commented on patch set 1 05/29/16, 19:12
thx helmut. we had a chat about that, i'll try to say the same as helmut here with other words only: in middle-term, it would be cool if the package manager is not loaded at all during "regular" runtime. the problem that is solved here is getting rid of typo3-loaded-ext global and substituting it with calls to the pm, but in most cases the only concern that is handled is path resolution. path resolution should later be handled by something different than the package manager, so maybe this change could be an opportunity to introduce a facade for that now that (for now) uses the pm to resolve path issues. -
Benni Mack commented on patch set 1 07/28/16, 06:22
OK. I think I get your point. How about going the following route: - We only start to replace current custom implementations where ext_emconf.php is loaded and evaluated manually (see NewRecordController, EXT:about, EXT:documentation, EXT:rtehtmlarea and EXT:extensionmanager) to be replaced by the package manager? As this current patch changes too much and in a possible non-performant way, it would be wise to streamline the evaluation of the metadata part into one place - the Package Manager. Calls within these locations are not about paths but about metadata then, does this make sense to you? -
Benni Mack abandoned the change 11/30/16, 16:43