Review TYPO3_7-6 Merged

48329[BUGFIX] Re-enables fileDenyPattern check for admin users

Wouter Wolters CR +2 V +2 Normal +53 −5 updated 05/27/16, 17:50

Commit message

When an admin user tries to upload a file which has a fileextension
that is included in the fileDenyPattern, the upload is denied.

With the security fix in #51326 admin users are now able to change
the extension of a file to any value, since the fileDenyPattern is
not checked for admin users. This leads to the situation, that admin
users can create/rename files in the filelist with a fileextension
of their choice.

To keep the behavior consistent, this patch re-enables the check
of the fileDenyPattern for admin users in the filelist.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 2

Review log 5

  1. Wouter Wolters commented on patch set 1 05/27/16, 12:11

    Cherry Picked from branch master.
  2. Helmut Hummel commented on patch set 1 V -1 05/27/16, 16:56

    for some reason, I now get 2 flash messages, when I try to rename a file to have .php On master same functionality is fine
  3. Helmut Hummel commented on patch set 1 CR +2 V +2 05/27/16, 17:20

    Ok. this is unrelated to this change and is just current state in 7.6
  4. Helmut Hummel commented on patch set 1 05/27/16, 17:50

    Straight cherry pick, not complex change, manual test successful, unit and functional tests green
  5. Gerrit merged patch set 1 05/27/16, 17:50