Review TYPO3_6-2 Merged

48335[BUGFIX] Re-enables fileDenyPattern check for admin users

Torben Hansen CR +2 V +2 Normal +51 −5 updated 05/27/16, 17:53

Commit message

When an admin user tries to upload a file which has a fileextension
that is included in the fileDenyPattern, the upload is denied.

With the security fix in #51326 admin users are now able to change
the extension of a file to any value, since the fileDenyPattern is
not checked for admin users. This leads to the situation, that admin
users can create/rename files in the filelist with a fileextension
of their choice.

To keep the behavior consistent, this patch re-enables the check
of the fileDenyPattern for admin users in the filelist.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 2

Review log 3

  1. Torben Hansen uploaded patch set 1 05/27/16, 13:54

  2. Helmut Hummel commented on patch set 1 CR +2 V +2 05/27/16, 17:52

    simple patch, unit tests green, manual test successful. waiting for functionals to complete and will merge then
  3. Gerrit merged patch set 1 05/27/16, 17:53