48337[TASK] Use a getter for the LanguageService in ext:version
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stephan Großberndt +1
-
Verified V +2
- Markus Klein +2
- Stephan Großberndt +1
Issues 1
Files 4
Review log 19
-
Wouter Wolters uploaded patch set 1 05/27/16, 14:07
-
Wouter Wolters uploaded patch set 2 05/27/16, 14:14
-
Michael Oehlhof voted on patch set 2 CR +1 05/27/16, 14:39
-
Markus Klein voted on patch set 2 CR +1 V +1 05/27/16, 14:43
-
Benni Mack commented on patch set 2 05/27/16, 16:15
-
Wouter Wolters commented on patch set 3 05/27/16, 16:17
Published edit on patch set 2. -
Markus Klein voted on patch set 3 CR +1 V +1 05/27/16, 16:21
-
Michael Oehlhof voted on patch set 3 CR +1 V +1 05/27/16, 18:00
-
Wouter Wolters uploaded patch set 4 05/28/16, 08:50
-
Markus Klein commented on patch set 4 CR -1 05/28/16, 09:14
on it -
Markus Klein uploaded patch set 5 05/28/16, 09:19
-
Markus Klein voted on patch set 5 CR +1 V +1 05/28/16, 09:20
-
Stephan Großberndt commented on patch set 5 CR -1 05/28/16, 09:48
on it -
Stephan Großberndt uploaded patch set 6 05/28/16, 10:02
-
Stephan Großberndt voted on patch set 6 CR +1 05/28/16, 10:03
-
Stephan Großberndt voted on patch set 6 V +1 05/28/16, 10:25
-
Stephan Großberndt commented on patch set 6 05/28/16, 10:27
it seems no one tested the VersionView ;) that is outout htmlspecialchar'd I'll create an issue and a patch for that -
Markus Klein voted on patch set 6 CR +2 V +2 05/28/16, 10:28
-
Gerrit merged patch set 6 05/28/16, 10:28
DataHandlerHook.php:578