Review main Merged

48337[TASK] Use a getter for the LanguageService in ext:version

Wouter Wolters CR +2 V +2 Normal +85 −47 updated 05/28/16, 10:28

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Stephan Großberndt +1
  • Verified V +2
    • Markus Klein +2
    • Stephan Großberndt +1

Issues 1

Files 4

Review log 19

  1. Wouter Wolters uploaded patch set 1 05/27/16, 14:07

  2. Wouter Wolters uploaded patch set 2 05/27/16, 14:14

  3. Michael Oehlhof voted on patch set 2 CR +1 05/27/16, 14:39

  4. Markus Klein voted on patch set 2 CR +1 V +1 05/27/16, 14:43

  5. Benni Mack commented on patch set 2 05/27/16, 16:15

    DataHandlerHook.php:578

    you can replace this one (= $GLOBALS['LANG'] as well.
  6. Wouter Wolters commented on patch set 3 05/27/16, 16:17

    Published edit on patch set 2.
  7. Markus Klein voted on patch set 3 CR +1 V +1 05/27/16, 16:21

  8. Michael Oehlhof voted on patch set 3 CR +1 V +1 05/27/16, 18:00

  9. Wouter Wolters uploaded patch set 4 05/28/16, 08:50

  10. Markus Klein commented on patch set 4 CR -1 05/28/16, 09:14

    on it
  11. Markus Klein uploaded patch set 5 05/28/16, 09:19

  12. Markus Klein voted on patch set 5 CR +1 V +1 05/28/16, 09:20

  13. Stephan Großberndt commented on patch set 5 CR -1 05/28/16, 09:48

    on it
  14. Stephan Großberndt uploaded patch set 6 05/28/16, 10:02

  15. Stephan Großberndt voted on patch set 6 CR +1 05/28/16, 10:03

  16. Stephan Großberndt voted on patch set 6 V +1 05/28/16, 10:25

  17. Stephan Großberndt commented on patch set 6 05/28/16, 10:27

    it seems no one tested the VersionView ;) that is outout htmlspecialchar'd I'll create an issue and a patch for that
  18. Markus Klein voted on patch set 6 CR +2 V +2 05/28/16, 10:28

  19. Gerrit merged patch set 6 05/28/16, 10:28