Review main Merged

48346[TASK] Remove second parameter of sL - Part 3/3

Valentin Despa CR +2 V +2 Hard +144 −144 updated 05/28/16, 08:41

Commit message

Remove the second parameter of sL and replace it
with htmlspecialchars directly in the code.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 2

Files 40

Show 20 more files

Review log 8

  1. Valentin Despa uploaded patch set 1 05/27/16, 17:23

  2. Markus Klein voted on patch set 1 CR +1 V +1 05/28/16, 08:13

  3. Wouter Wolters commented on patch set 1 CR -1 05/28/16, 08:14

    CleanerFieldProvider.php:128

    double check this one, flashmessages do not need to be enconded when adding the message. Encoding is done on output.

    CleanerFieldProvider.php:151

    same here

    CleanerFieldProvider.php:176

    same here
  4. Markus Klein voted on patch set 1 CR 0 V 0 05/28/16, 08:16

  5. Valentin Despa uploaded patch set 2 05/28/16, 08:31

  6. Markus Klein voted on patch set 2 CR +1 V +1 05/28/16, 08:39

  7. Wouter Wolters voted on patch set 2 CR +2 V +2 05/28/16, 08:41

  8. Gerrit merged patch set 2 05/28/16, 08:41