Review main Merged

48353[TASK] Deprecate the argument 'hsc' for getLL, getLLL and sL

Valentin Despa CR +2 V +2 Easy +47 −3 updated 05/28/16, 12:34

Commit message

This patch deprecates the parameter 'hsc' within the following
methods of TYPO3\CMS\Lang\LanguageService:

    * getLL
    * getLLL
    * sL

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 7

  1. Valentin Despa uploaded patch set 1 05/28/16, 11:32

  2. Valentin Despa uploaded patch set 2 05/28/16, 12:23

  3. Wouter Wolters commented on patch set 2 05/28/16, 12:26

    Deprecation-71917-DeprecateTheArgumentHscForGetLLGetLLLAndSL.rst:10

    :php:`getLL()` The rest for the function below.
  4. Wouter Wolters commented on patch set 3 05/28/16, 12:27

    Published edit on patch set 2.
  5. Wouter Wolters voted on patch set 3 CR +1 V +1 05/28/16, 12:28

  6. Markus Klein voted on patch set 3 CR +2 V +2 05/28/16, 12:34

  7. Gerrit merged patch set 3 05/28/16, 12:34