Review main Merged

4836[TASK] Improve rendering of plugins in page module

Georg Ringer CR +2 V +2 Easy +5 −5 updated 06/03/13, 20:49

Commit message

The rendering of the content element "plugin" can be highly improved
by changing just a fiew lines.

Changes:
- Remove "CODE:" when not needed
- Remove the "Insert plugin" as there is no additional information

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Gebert +2
    • Soren Malling +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 8

  1. Georg Ringer uploaded patch set 2 09/13/11, 20:18

  2. Soren Malling commented on patch set 1 09/13/11, 20:18

    Fails Every content element gets the text "Default plugin", including text element. Please see screenshot in Forge. I guess this isn't the purpose :)
  3. Soren Malling commented on patch set 2 V 0 09/13/11, 20:18

    Nice, makes the content elements much nicer. Next step could be to determine what the "Default" string before "plugin", "text" etc. is for and maybe remove that to, if it doesn't serve a purpose.
  4. Philipp Gampe commented on patch set 2 09/13/11, 20:18

    Verified; Looks good to me, but someone else must approve Works fine. The default comes from the language. However this does not make sense, because the page module only shows one language anyway. But this is not the scope of this patch, thus giving my review.
  5. Mr. Jenkins commented on patch set 1 09/13/11, 20:18

  6. Mr. Jenkins commented on patch set 2 09/13/11, 20:18

  7. Steffen Gebert commented on patch set 2 V 0 09/13/11, 20:18

    by team member; Looks good to me, approved
  8. Steffen Gebert merged patch set 2 09/13/11, 20:18