Review main Merged

48363[TASK] Better explain when a cookie with a lifetime will be set

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 05/29/16, 07:52

Commit message

A cookie with a lifetime will only be set when the option permalogin
is greater than or equals to 0. If this is not true it will become
a session cookie.

Review

  • Code review CR +2
    • Markus Klein +2
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 7

  1. Wouter Wolters uploaded patch set 1 05/28/16, 15:04

  2. Markus Klein commented on patch set 1 05/28/16, 16:29

    DefaultConfiguration.php:1093

    >= ?
  3. Markus Klein commented on patch set 1 CR +1 V +1 05/28/16, 16:31

    forget my comment
  4. Michael Oehlhof voted on patch set 1 CR +1 V +1 05/28/16, 22:54

  5. Markus Klein voted on patch set 1 CR +2 V +2 05/29/16, 07:52

  6. Gerrit merged patch set 1 05/29/16, 07:52

  7. Markus Klein commented on patch set 2 05/29/16, 07:52

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 3beb923e7f24ed74957396a528b4ff7af770be24