48366[TASK] Remove $db property in UserAuthentication classes
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 5
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php+4 −3
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php4+0 −7
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+2 −2
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+4 −3
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php+12 −8
Review log 14
-
Markus Klein uploaded patch set 1 05/28/16, 16:14
-
Christian Kuhn voted on patch set 1 CR +1 05/28/16, 16:20
-
Christian Kuhn voted on patch set 1 V +1 05/28/16, 16:24
-
Wouter Wolters voted on patch set 1 CR +2 V +2 05/28/16, 16:31
-
Gerrit merged patch set 1 05/28/16, 16:31
-
Nicole Hummel commented on patch set 2 06/01/16, 19:59
-
Markus Klein commented on patch set 2 06/02/16, 09:36
AbstractUserAuthentication.php:348ReplyWhat do you mean Nicole? -
Wouter Wolters commented on patch set 2 06/02/16, 09:52
AbstractUserAuthentication.php:348ReplyThe constructor is now empty. -
Nicole Hummel commented on patch set 2 06/02/16, 10:15
AbstractUserAuthentication.php:348ReplyRight, the sole function in the constructor was remove and an empty constructor function was left. any purpose? -
Markus Klein commented on patch set 2 06/02/16, 12:58
Funny PHP thing. Subclasses override the constructor and call parent::. In that case the constructor must be present in the parent class, otherwise this fails hard. We tried that out in this case! -
Nicole Hummel commented on patch set 2 06/03/16, 06:32
@Markus: Thanks for clearing this up. Should we add any comment to prevent irritation? -
Markus Klein commented on patch set 2 06/03/16, 08:02
Yes maybe. But maybe we should set another strict rule in CGL: Every class must have a default constructor defined, no matter if empty or not. Otherwise this is hell if you extend a class in an extension and the constructor is there or not and you fail or not -
Nicole Hummel commented on patch set 2 06/03/16, 09:00
I don't get your comment :-) If I extend a class I usually know if there is a constructor or not. Don't I? I will do a quick follow up to add a comment in the constructor of that abstract class here -
Nicole Hummel commented on patch set 2 06/03/16, 09:05
AbstractUserAuthentication.php:348