Review main Merged

48366[TASK] Remove $db property in UserAuthentication classes

Markus Klein CR +2 V +2 Easy +22 −23 updated 06/03/16, 09:05

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 5

Review log 14

  1. Markus Klein uploaded patch set 1 05/28/16, 16:14

  2. Christian Kuhn voted on patch set 1 CR +1 05/28/16, 16:20

  3. Christian Kuhn voted on patch set 1 V +1 05/28/16, 16:24

  4. Wouter Wolters voted on patch set 1 CR +2 V +2 05/28/16, 16:31

  5. Gerrit merged patch set 1 05/28/16, 16:31

  6. Nicole Hummel commented on patch set 2 06/01/16, 19:59

    AbstractUserAuthentication.php:348

    Why wasn't the constructor removed here?
  7. Markus Klein commented on patch set 2 06/02/16, 09:36

    AbstractUserAuthentication.php:348 Reply

    What do you mean Nicole?
  8. Wouter Wolters commented on patch set 2 06/02/16, 09:52

    AbstractUserAuthentication.php:348 Reply

    The constructor is now empty.
  9. Nicole Hummel commented on patch set 2 06/02/16, 10:15

    AbstractUserAuthentication.php:348 Reply

    Right, the sole function in the constructor was remove and an empty constructor function was left. any purpose?
  10. Markus Klein commented on patch set 2 06/02/16, 12:58

    Funny PHP thing. Subclasses override the constructor and call parent::. In that case the constructor must be present in the parent class, otherwise this fails hard. We tried that out in this case!
  11. Nicole Hummel commented on patch set 2 06/03/16, 06:32

    @Markus: Thanks for clearing this up. Should we add any comment to prevent irritation?
  12. Markus Klein commented on patch set 2 06/03/16, 08:02

    Yes maybe. But maybe we should set another strict rule in CGL: Every class must have a default constructor defined, no matter if empty or not. Otherwise this is hell if you extend a class in an extension and the constructor is there or not and you fail or not
  13. Nicole Hummel commented on patch set 2 06/03/16, 09:00

    I don't get your comment :-) If I extend a class I usually know if there is a constructor or not. Don't I? I will do a quick follow up to add a comment in the constructor of that abstract class here
  14. Nicole Hummel commented on patch set 2 06/03/16, 09:05