Review main Merged

48371[BUGFIX] Simulate submit button for rsaauth form submit

Nicole Hummel CR +2 V +2 Easy +19 −12 updated 03/22/18, 11:34

Commit message

This patch adds the name and value of the first submit button found in a
form to the input field used to send the form.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1922

  1. Nicole Hummel uploaded patch set 1 05/28/16, 17:13

  2. Markus Klein commented on patch set 1 05/28/16, 18:05

    RsaEncryption.js:112

    what about the case when the first submit button is a <button type="submit" ?
  3. Nicole Hummel uploaded patch set 2 08/29/16, 10:06

  4. Nicole Hummel commented on patch set 1 08/29/16, 10:06

    RsaEncryption.js:112 Reply

    Done
  5. TYPO3com voted on patch set 2 V +1 08/29/16, 10:08 Completed build in 02m 54s on Mon, 29 Aug, 12:08 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2387

  6. Wouter Wolters voted on patch set 2 CR +1 09/28/16, 14:24

  7. Markus Klein commented on patch set 2 09/29/16, 22:24

    RsaEncryptionModule.js:123

    button[type=submit]? Left out on purpose?
  8. Frank Nägler commented on patch set 2 CR -1 10/21/16, 13:27

    RsaEncryptionModule.js:123 Reply

    the check for the button type is important, because a button with type="reset" is not useful and would result in a wrong behavior.
  9. Stefan Neufeind uploaded patch set 3 12/07/17, 07:33

  10. Stefan Neufeind commented on patch set 3 V +1 12/07/17, 07:35

    Added 8.7 to the releases-line. Added [type=submit] to the button-search in RsaEncryptionModule.js. Do we need something similar in RsaEncryption.js? Verified it (still) works for me on the backend-login-form.

    RsaEncryptionModule.js:123 Reply

    Done
  11. TYPO3com voted on patch set 3 V +1 12/07/17, 07:45 Completed build in 11m 40s on Thu, 7 Dec, 08:45 AM Test Summary: 56991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17278

  12. Stefan Neufeind commented on patch set 3 12/11/17, 08:21

    ping
  13. Frank Nägler commented on patch set 3 01/29/18, 13:51

    RsaEncryption.js:117

    maybe add a toLowerCase() here too? I am not sure, if all browser will provide the type as lowercase letters.
  14. Andreas Kienast uploaded patch set 4 02/05/18, 19:09

  15. TYPO3com voted on patch set 4 V +1 02/05/18, 19:16 Completed build in 07m 22s on Mon, 5 Feb, 08:16 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18955

  16. Markus Klein voted on patch set 4 CR +1 02/06/18, 09:12

  17. Stefan Neufeind commented on patch set 4 V +1 CR +1 02/06/18, 09:27

    reapplying my vote
  18. Markus Klein voted on patch set 4 V +2 CR +2 03/09/18, 22:21

  19. Markus Klein merged patch set 5 03/09/18, 22:21

  20. Markus Klein commented on patch set 5 03/09/18, 22:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 82036e0933cda6952b075a957f53ea231c92af99
  21. Stephan Großberndt commented on patch set 5 03/15/18, 09:40

    Introduced a firefox login bug, see https://review.typo3.org/#/c/56142/
  22. Markus Klein commented on patch set 5 03/22/18, 11:34

    Patch has been reverted with https://review.typo3.org/56394