Review main Merged

48379[BUGFIX] Do not throw away active session

Helmut Hummel CR +2 V +2 Easy +12 −13 updated 07/10/16, 08:13

Commit message

Previously an active and valid session was dismissed, if login
credentials are sent again.

Now we do not start the user authentication if we have a valid session.

This also fixes weird side effects during backend login, when
it says that token is not valid.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2
    • Helmut Hummel +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1820

  1. Helmut Hummel uploaded patch set 1 05/28/16, 21:03

  2. Helmut Hummel updated the commit message in patch set 2 05/28/16, 21:04

  3. Markus Klein voted on patch set 2 CR +1 05/28/16, 21:22

  4. Markus Klein commented on patch set 2 V +1 06/11/16, 13:21

    worked for the last two weeks
  5. Helmut Hummel commented on patch set 2 06/12/16, 21:10

    Thanks a lot for the tests!
  6. Mathias Schreiber updated the commit message in patch set 3 06/14/16, 09:16

  7. Mathias Schreiber commented on patch set 3 06/14/16, 09:17

    I fixed the Releases line to make it compliant (and Forger no longer breaks as well :))
  8. Markus Klein voted on patch set 3 CR +1 V +1 06/14/16, 09:17

  9. Christian Kuhn commented on patch set 3 06/14/16, 12:40

    AbstractUserAuthentication.php:600

    could this comment be rephrase a bit along the way? it sounds weird and is a hard to understand at first read.
  10. Oliver Klee commented on patch set 3 CR -1 06/14/16, 14:45

    What is the ticket ID?
  11. Markus Klein updated the commit message in patch set 4 07/08/16, 19:43

  12. Markus Klein commented on patch set 5 07/08/16, 19:45

    Published edit on patch set 4.
  13. Markus Klein voted on patch set 5 CR +1 V +1 07/08/16, 19:46

  14. TYPO3com voted on patch set 4 V +1 07/08/16, 19:52 Completed build in 09m 14s on Fri, 8 Jul, 09:52 PM Test Summary: 18406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-630

  15. TYPO3com voted on patch set 5 V +1 07/08/16, 19:57 Completed build in 11m 49s on Fri, 8 Jul, 09:57 PM Test Summary: 18406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-631

  16. Christian Kuhn commented on patch set 5 CR +1 07/09/16, 11:46

    looks good to me. for the one who merges this: maybe we should consider having this patch in master only for a while and do the backport a bit later if we're very sure it doesn't harm on master? i'm asking since the session stuff tends to be relatively fragile and we maybe want to be on the safe side here to not risk issues in 7.6. don't hesitate to backport directly if you have a different view, though.
  17. Markus Klein commented on patch set 5 07/09/16, 12:55

    Let's put it into master right now, early in 8.3, so we get more experience from the wild. +1 for keeping the backport a bit delayed. I can take care about this then.
  18. Helmut Hummel commented on patch set 5 CR +2 V +2 07/09/16, 20:38

    sounds like a solid plan. thanks a bunch! let's see how this works out in master
  19. Gerrit merged patch set 5 07/09/16, 20:38

  20. Markus Klein commented on patch set 6 07/10/16, 08:13

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 483ae1a5c1e5bd8079da55b46e6c21f675f65a87