Review main Merged

48383[BUGFIX] Load CSH for flexforms again

Wouter Wolters CR +2 V +2 Easy +6 −2 updated 06/03/16, 16:05

Commit message

The cshKey is not correctly set up. Check for array as well and use
the first key if it exists.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Marco Bresch +1
  • Verified V +2
    • Christian Kuhn +2
    • Marco Bresch +1

Issues 1

Files 2

Review log 12

  1. Wouter Wolters uploaded patch set 1 05/29/16, 10:49

  2. Christian Kuhn voted on patch set 1 CR +1 05/29/16, 11:17

  3. Christian Kuhn commented on patch set 1 CR 0 05/29/16, 11:19

    FlexFormNoTabsContainer.php:63

    !== '' could / should be tested for, too.
  4. Wouter Wolters commented on patch set 2 05/30/16, 09:02

    Published edit on patch set 1.
  5. Georg Tiefenbrunn commented on patch set 2 05/30/16, 10:32

    typo3/sysext/backend/Classes/Form/Container/FlexFormTabsContainer.php also needs this fix (see https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Form/Container/FlexFormTabsContainer.php#l64).
  6. Wouter Wolters uploaded patch set 3 06/01/16, 17:49

  7. Marco Bresch commented on patch set 3 V +1 06/03/16, 14:22

    Works on master
  8. Christian Kuhn voted on patch set 3 CR +1 V +1 06/03/16, 15:53

  9. Marco Bresch voted on patch set 3 CR +1 06/03/16, 16:04

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 06/03/16, 16:04

  11. Gerrit merged patch set 3 06/03/16, 16:05

  12. Christian Kuhn commented on patch set 4 06/03/16, 16:05

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit ec5df7acc4bd9d1ebfb53ee18ba05e95386d23f6