48391[BUGFIX] Make Install Tool forms submitable via keyboard
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Susi Moog +1
-
Verified V +2
- Georg Ringer +2
- Susi Moog +1
Issues 1
Files 14
- typo3/sysext/install/Resources/Private/Partials/Action/Common/SubmitButton.html+2 −1
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Context/Custom.html+6 −5
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Context/Debug.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Context/Live.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/ExtbaseObjectCache/Apc.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/ExtbaseObjectCache/Apcu.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/ExtbaseObjectCache/Database.html+3 −3
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Image/Custom.html+6 −5
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Image/GraphicsMagick.html+3 −3
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Image/ImageMagick6.html+3 −3
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Mail/Custom.html+5 −4
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Mail/Sendmail.html+2 −2
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Context.html+1 −1
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/Configuration/Image.html+1 −1
Review log 15
-
Markus Klein uploaded patch set 1 05/29/16, 13:15
-
Nicole Hummel commented on patch set 1 V -1 05/29/16, 14:21
Not working here -
Markus Klein uploaded patch set 2 05/29/16, 14:37
-
Markus Klein updated the commit message in patch set 3 05/29/16, 14:38
-
Markus Klein wrote 05/29/16, 14:38
Topic set to Install Tool -
Wouter Wolters commented on patch set 3 CR -1 05/29/16, 19:25
I would say not for 6.2 here. The Install Tool styling has been rewritten in 7 to Bootstrap. -
Markus Klein commented on patch set 3 05/29/16, 22:11
Wouter: The bug is the same in 6.2. I made the backport already. This has nothing todo with styling. -
Markus Klein commented on patch set 3 05/29/16, 22:11
Ah sorry. I did of course not make the backport yet. -
Markus Klein uploaded patch set 4 06/11/16, 13:25
-
Markus Klein commented on patch set 4 06/11/16, 13:26
I rebased the thing and pushed the slightly different 7.6 backport too -
Susi Moog commented on patch set 4 CR +1 06/13/16, 13:11
can't reproduce the bug, as I can submit the forms with keyboard only even before the patch (tried database analyzer, all configuration, site name...) -
Markus Klein commented on patch set 4 06/13/16, 13:37
Susi, you tested the wrong forms... As you can see the changes touch the files in the presets only. -
Susi Moog commented on patch set 4 V +1 06/13/16, 16:06
Thanks Markus ;) For some reason I thought it concerned all forms as the partial Common/SubmitButton was changed... -
Georg Ringer voted on patch set 4 CR +2 V +2 06/13/16, 18:24
-
Gerrit merged patch set 4 06/13/16, 18:24