Review main Merged

48391[BUGFIX] Make Install Tool forms submitable via keyboard

Markus Klein CR +2 V +2 Normal +40 −36 updated 06/13/16, 18:24

Commit message

Additionally fix missing input-label association and simplify
Fluid inline if usage.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Susi Moog +1
  • Verified V +2
    • Georg Ringer +2
    • Susi Moog +1

Issues 1

Files 14

Review log 15

  1. Markus Klein uploaded patch set 1 05/29/16, 13:15

  2. Nicole Hummel commented on patch set 1 V -1 05/29/16, 14:21

    Not working here
  3. Markus Klein uploaded patch set 2 05/29/16, 14:37

  4. Markus Klein updated the commit message in patch set 3 05/29/16, 14:38

  5. Markus Klein wrote 05/29/16, 14:38

    Topic set to Install Tool
  6. Wouter Wolters commented on patch set 3 CR -1 05/29/16, 19:25

    I would say not for 6.2 here. The Install Tool styling has been rewritten in 7 to Bootstrap.
  7. Markus Klein commented on patch set 3 05/29/16, 22:11

    Wouter: The bug is the same in 6.2. I made the backport already. This has nothing todo with styling.
  8. Markus Klein commented on patch set 3 05/29/16, 22:11

    Ah sorry. I did of course not make the backport yet.
  9. Markus Klein uploaded patch set 4 06/11/16, 13:25

  10. Markus Klein commented on patch set 4 06/11/16, 13:26

    I rebased the thing and pushed the slightly different 7.6 backport too
  11. Susi Moog commented on patch set 4 CR +1 06/13/16, 13:11

    can't reproduce the bug, as I can submit the forms with keyboard only even before the patch (tried database analyzer, all configuration, site name...)
  12. Markus Klein commented on patch set 4 06/13/16, 13:37

    Susi, you tested the wrong forms... As you can see the changes touch the files in the presets only.
  13. Susi Moog commented on patch set 4 V +1 06/13/16, 16:06

    Thanks Markus ;) For some reason I thought it concerned all forms as the partial Common/SubmitButton was changed...
  14. Georg Ringer voted on patch set 4 CR +2 V +2 06/13/16, 18:24

  15. Gerrit merged patch set 4 06/13/16, 18:24